DX-2726 Initial Development of Linter CLI #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ran npm init and setup ts package coded lint command with --save option logic to download remote ruleset with local fallback
Not needed since we are publishing to GH registry
bpateldx
requested changes
Aug 4, 2022
tests/cli.test.js
Outdated
| }); | ||
|
|
||
| it("should run lint command", async () => { | ||
| expect(typeof testLint("./tests/fixtures/testSpec.yaml")).toBe("string"); |
There was a problem hiding this comment.
Suggest adding additional validation inspecting the string for error related message and error counts.
There was a problem hiding this comment.
Or better test one good spec and one bad spec
ajrice6713
changed the title
Also set result to be an array of objects instead of a single object
bpateldx
previously approved these changes
Aug 9, 2022
brianluisgomez
approved these changes
Aug 10, 2022
ckoegel
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.