Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there 👋
We're using your library in our stack and have noticed that there are now warnings being thrown for usage of deprecated Faraday methods.
Specifically:
This PR updates the usage of
basic_auth
to be in line with the suggestion at that link.I searched for other usages of
basic_auth
in here but this seems to be the only instance.The specs ended up getting a little funky since this new approach adds the auth at the middleware level and not on the connection itself. This means that the Authorization headers don't exist on the connection, but are added once the request is in flight. I modified the specs to use an approach used by Faraday itself.
Please let me know if you have any questions and thanks for the consideration!