feat(router): Update beforeEnter typing #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dethell
requested review from
ChadKillingsworth,
jrobinson01,
barronhagerman,
jivewise and
chrisgubbels
as code owners
dethell
removed request for
ChadKillingsworth,
jrobinson01,
jivewise and
barronhagerman
dethell
force-pushed
the
beforeenter-update-typing
branch
3 times, most recently
from
1443b05 to
7124b76
Compare
dethell
force-pushed
the
beforeenter-update-typing
branch
from
7124b76 to
3b4de9b
Compare
chrisgubbels
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
beforeEntertyping so that instead ofPromise<undefined>we havePromise<unknown>because when implementing dynamic imports in thebeforeEnterfunction the TS linter gives errors about the type of the dynamic import.