fix(syntax): RouteConfig typedef #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barronhagerman
requested review from
ChadKillingsworth,
jrobinson01,
jivewise and
chrisgubbels
as code owners
* Fixes the `RouteConfig` `typedef` annotation (see https://github.com/google/closure-compiler/wiki/Annotating-JavaScript-for-the-Closure-Compiler#typedef-type)
barronhagerman
force-pushed
the
fix-routeconfig-typedef
branch
from
30ea9a8 to
2a9ed4d
Compare
barronhagerman
removed request for
ChadKillingsworth,
jrobinson01 and
jivewise
chrisgubbels
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the
RouteConfigtypedefannotation that was added in #67 because it currently does not follow the correct syntax (see https://github.com/google/closure-compiler/wiki/Annotating-JavaScript-for-the-Closure-Compiler#typedef-type).How to test
yarn linkthis repository into a project that uses the router and is compiled with Closure CompilerRouteConfigtype definition