Implement logger service #3
Conversation
Signed-off-by: Barry Xu <barry.xu@sony.com>
|
@iuhilnehc-ynos |
rclcpp/include/rclcpp/node_interfaces/node_builtin_executor.hpp
Outdated
Show resolved
Hide resolved
rclcpp/include/rclcpp/node_interfaces/node_builtin_executor.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Barry Xu <barry.xu@sony.com>
|
@iuhilnehc-ynos Please check again |
| private: | ||
| RCLCPP_DISABLE_COPY(NodeBuiltinExecutor) | ||
| class NodeBuiltinExecutorImpl; | ||
| std::shared_ptr<NodeBuiltinExecutorImpl> impl_; |
There was a problem hiding this comment.
Please use std::unique_ptr instead of std::shared_ptr.
There was a problem hiding this comment.
It seems you haven't updated it.
| { | ||
| int ret = 0; | ||
| auto result = rcl_interfaces::msg::SetLoggerLevelsResult(); | ||
| for (auto & l : request->levels) { |
There was a problem hiding this comment.
| for (auto & l : request->levels) { | |
| for (auto & level : request->levels) { |
There was a problem hiding this comment.
IMO, the meaning of levels in ros2/rcl_interfaces#154 is vague.
Because it seems like a level array, the level might be treated as the uint8 level in the LoggerLevel.
|
I don't know which way |
Signed-off-by: Barry Xu <barry.xu@sony.com>
Signed-off-by: Barry Xu <barry.xu@sony.com>
| node_base_, | ||
| node_topics_, | ||
| node_services_, | ||
| node_logging_, |
There was a problem hiding this comment.
Please remove node_logging_.
There was a problem hiding this comment.
Yes. I have removed it before pushing to github rclcpp
| @@ -1087,6 +1088,8 @@ class LifecycleNode : public node_interfaces::LifecycleNodeInterface, | |||
| rclcpp::node_interfaces::NodeTimeSourceInterface::SharedPtr node_time_source_; | |||
| rclcpp::node_interfaces::NodeWaitablesInterface::SharedPtr node_waitables_; | |||
|
|
|||
| rclcpp::NodeBuiltinExecutor::SharedPtr node_builtin_executor_; | |||
There was a problem hiding this comment.
It should be updated as well.
There was a problem hiding this comment.
Yes. Updated before pushing to github rclcpp
No description provided.