Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/adresse v2 carto ban #1863

Merged
merged 13 commits into from
Oct 31, 2024
Merged

Feat/adresse v2 carto ban #1863

merged 13 commits into from
Oct 31, 2024

Conversation

nkokla
Copy link
Contributor

@nkokla nkokla commented Oct 23, 2024

Add new Page "/carte-base-adresse-nationale" with Ban Search Tools and BAN Data Explorer.

@nkokla nkokla force-pushed the feat/adresse-v2-carto-ban branch 4 times, most recently from 73d5b1e to 6d62926 Compare October 23, 2024 13:38
Copy link
Contributor

@IGNFBourcier IGNFBourcier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fonctionnement ok
des amélioration a voir sur le l'explorateur:
la recherche debounce non fonctionel?, requte sur l'api lookup avec le contenu du text saisie lors du 1 er affichage des propositions.
sur le tiroir descriptif (Aside avec addresse) la scrollbar n'est pas accessible, si on utilise on déplace la map.

.env.default Show resolved Hide resolved
@vinsag vinsag self-requested a review October 27, 2024 16:52
@vinsag
Copy link
Member

vinsag commented Oct 27, 2024

Quelques commentaire sur la carte:

  • Il faut enlever le centre d'aide qui cache la carte
  • Problème de visualisation de la carte quand on arrive sur la carte une première fois
  • Mettre le numéro et la rue sur la même ligne quand c'est possible.
  • Manque l'information certifié mais c'est peut-être en cours.

Copy link
Member

@vinsag vinsag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok suite à mes commentaires

@nkokla nkokla merged commit dbadf2f into main Oct 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants