fix: make middleware work with all http methods #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fufeck
reviewed
Oct 1, 2024
MaGOs92
force-pushed
the
gfay_fix_middleware-works-with-all-http-methods
branch
from
8c3398f
to
234285c
Compare
fufeck
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mattermost : https://mattermost.incubateur.net/betagouv/pl/iy7nwfkmo3domc91d4jf41smfy
Problème : Quand on applique un middleware sur une route en particulier, il ne fonctionne qu'avec la méthode http attendue par le controller. Le souci c'est que pour les methodes HEAD et OPTIONS, le middleware ne s'applique pas et le serveur renvoie une 500.
=> Appliquer les middleware pour toutes les méthodes HTTP