Merge pull request #46 from BaseAdresseNationale/antoineludeau/fix-co…

…mmon-toponyms-delete-order

Fix common toponyms delete order

src/bal-converter/index.ts

@@ -51,11 +51,9 @@ export const sendBalToBan = async (bal: string) => {
   const banAddressesIdsToDelete = addressIdsReport.idsToDelete;
 
   // Order is important here. Need to handle common toponyms first, then adresses
-  const responseCommonToponyms = await Promise.all([
+  const responseCommonToponymsPromises = ([
     banToponymsToAdd.length > 0 && createCommonToponyms(banToponymsToAdd),
     banToponymsToUpdate.length > 0 && updateCommonToponyms(banToponymsToUpdate),
-    banToponymsIdsToDelete.length > 0 &&
-      deleteCommonToponyms(banToponymsIdsToDelete),
   ]);
 
   const responseAddresses = await Promise.all([
@@ -65,6 +63,13 @@ export const sendBalToBan = async (bal: string) => {
       deleteAddresses(banAddressesIdsToDelete),
   ]);
 
+  // To delete common toponyms, we need to wait for addresses to be deleted first
+  responseCommonToponymsPromises.push(banToponymsIdsToDelete.length > 0 &&
+      deleteCommonToponyms(banToponymsIdsToDelete),
+  )
+
+  const responseCommonToponyms = await Promise.all(responseCommonToponymsPromises);
+
   const responses = [...responseAddresses, ...responseCommonToponyms];
 
   return responses.reduce((acc, cur, i) => {