Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified data schema for optional fields #38

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

antoineludeau
Copy link
Member

@antoineludeau antoineludeau commented Aug 22, 2023

This PR aims to NOT send to ban API useless information such as default values for :

  • "meta" : if no meta information, the "meta" field won't be sent anymore.
  • "geometry" : for addresses, geometry is required but for common toponyms, it is not. As a consequence, the "geometry" field won't be sent anymore if no data (ONLY common toponyms)
  • "suffix" : for addresses, if no suffix information, the "suffix" field won't be sent anymore.

@antoineludeau antoineludeau force-pushed the antoineludeau/modify-data-schemas branch from 08739e7 to c5e73ac Compare August 22, 2023 14:45
@antoineludeau antoineludeau self-assigned this Aug 22, 2023
@antoineludeau antoineludeau changed the title Modified data schema for meta and geometry fields Modified data schema for optional fields Aug 24, 2023
@antoineludeau antoineludeau merged commit 6ddd02c into master Aug 29, 2023
@antoineludeau antoineludeau deleted the antoineludeau/modify-data-schemas branch August 29, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ID-Fix] : Modification de la façon dont sont envoyées les données non requises vers API BAN
2 participants