Added check on BAL to detect use of BAN-ID #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoineludeau
force-pushed
the
antoineludeau/check-if-bal-use-ban-id
branch
from
5c17fce
to
5458192
Compare
antoineludeau
force-pushed
the
antoineludeau/check-if-bal-use-ban-id
branch
from
c6f2cfd
to
52b2a9e
Compare
antoineludeau
force-pushed
the
antoineludeau/check-if-bal-use-ban-id
branch
3 times, most recently
from
5ec23c1
to
d9cf4eb
Compare
nkokla
approved these changes
Nov 21, 2023
antoineludeau
force-pushed
the
antoineludeau/check-if-bal-use-ban-id
branch
2 times, most recently
from
2806d9f
to
a48159d
Compare
antoineludeau
force-pushed
the
antoineludeau/check-if-bal-use-ban-id
branch
from
a48159d
to
7cc0a48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
To be able to redirect the process of a BAL to the legacy process or to the new process using ban-ID APIs, we need to detect if the BAL (version 1.3 for now) is using the BAN-IDs or not.
Also, in order to test the process only for a few districts, we need to restrain the processing to a specific list.
Enhancement
This PR aims to add checks on each BAL line to detect :
1- if uid_adresse field is field out
2- if uid_adresse contains a valid main common toponym ID (uuid v4)
Also, we detect if district cog is part of the
accepted-cog-list.jsonIf all checks are true, id-fix process the BAL