Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Improves plist parsing for a better/easier development experience #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nidib
Copy link

@nidib nidib commented Feb 4, 2023

First of all, awesome project!

While reading the source code, I found a little bit tricky to understand where the app attributes were. Imagining a scenario where a new attribute needs to be used for some upcoming feature, I think this small change will make things a lot easier.

Important note: There is a small optional change at the getAppNamesWithIconPaths function. Where only file-tile items will be used, leaving out dock spacers.

The idea is to parse the Apple's Property list using the extremely popular npm package: plist
Here is a screenshot of how the parsed xml looks like:

  • Main object:
    CleanShot 2023-02-04 at 13 58 32@2x
  • Persistent apps:
    CleanShot 2023-02-04 at 13 59 13@2x

@@ -28,6 +28,7 @@
"fs-extra": "^11.1.0",
"node-fetch": "^3.3.0",
"open": "^8.4.0",
"plist": "^3.0.6",
"xml2js": "^0.4.23"
Copy link
Author

@nidib nidib Feb 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If accepted, this package should be removed.

@nidib nidib changed the title Improves plist parsing for a better/easier development experience WIP: Improves plist parsing for a better/easier development experience Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant