WIP: Improves plist parsing for a better/easier development experience #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, awesome project!
While reading the source code, I found a little bit tricky to understand where the app attributes were. Imagining a scenario where a new attribute needs to be used for some upcoming feature, I think this small change will make things a lot easier.
Important note: There is a small optional change at the
getAppNamesWithIconPaths
function. Where onlyfile-tile
items will be used, leaving out dock spacers.The idea is to parse the Apple's Property list using the extremely popular npm package: plist
Here is a screenshot of how the parsed xml looks like: