Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
PhotoViewAttacher
also usesOnTouchListener
, instead ofPhotoView
overridingonTouchEvent
, this made user of PhotoView unable to set their ownOnTouchListener
on top ofPhotoView
.For example, if I want to also be able to start a drag and drop (but not by long press, which is already available as a custom listener) when my drag action has gone outside of the view bound,
PhotoView
has no way to deal with this now.So I simply added an additional OnTouchListener.
If user does not add it, it won't affect any of the existing functionality of this library.
If user adds it and returned true, the on-going code in
OnTouch
ofPhotoViewAttacher
will not continue to execute.See if you agree to add this additional functionality. Thanks!