Skip to content

Commit

Permalink
Updates
Browse files Browse the repository at this point in the history
  • Loading branch information
martijn00 committed Mar 6, 2020
1 parent a3d858c commit e13e3ad
Show file tree
Hide file tree
Showing 20 changed files with 619 additions and 122 deletions.
3 changes: 3 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -78,3 +78,6 @@ csharp_new_line_before_catch = true
csharp_new_line_before_finally = true
csharp_new_line_before_members_in_object_initializers = true
csharp_new_line_before_members_in_anonymous_types = true

# Braces after if
csharp_prefer_braces = false
28 changes: 28 additions & 0 deletions .github/ISSUE_TEMPLATE/a-regression.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
---

name: 🔙 Regression
about: Report unexpected behavior that worked previously
---

## 🔙 Regression

<!--- Summary description of the regression --->

### Old (and correct) behavior

### Current behavior

### Reproduction steps

### Configuration

**Version:** 1.x

**Platform:**
- [ ] :iphone: iOS
- [ ] :robot: Android
- [ ] :checkered_flag: WPF
- [ ] :earth_americas: UWP
- [ ] :apple: MacOS
- [ ] :tv: tvOS
- [ ] :monkey: Xamarin.Forms
26 changes: 26 additions & 0 deletions .github/ISSUE_TEMPLATE/b-bug-report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
---

name: 🐛 Bug Report
about: Create a report to help us fix bugs and make improvements
---

## 🐛 Bug Report

<!--- Summary description of the bug --->

### Expected behavior

### Reproduction steps

### Configuration

**Version:** 1.x

**Platform:**
- [ ] :iphone: iOS
- [ ] :robot: Android
- [ ] :checkered_flag: WPF
- [ ] :earth_americas: UWP
- [ ] :apple: MacOS
- [ ] :tv: tvOS
- [ ] :monkey: Xamarin.Forms
24 changes: 24 additions & 0 deletions .github/ISSUE_TEMPLATE/c-feature-request.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
---

name: 🚀 Feature Request
about: Want to see something new included in the Framework? Submit it!
---

## 🚀 Feature Requests

<!--- Summary description of the feature --->

### Contextualize the feature
<!--- Where does it fit in the framework and why it's being included there. --->

### Describe the feature
<!--- Use as much detail as possible here! --->

### Platforms affected (mark all that apply)
- [ ] :iphone: iOS
- [ ] :robot: Android
- [ ] :checkered_flag: WPF
- [ ] :earth_americas: UWP
- [ ] :apple: MacOS
- [ ] :tv: tvOS
- [ ] :monkey: Xamarin.Forms
22 changes: 22 additions & 0 deletions .github/ISSUE_TEMPLATE/d-enhancement-proposal.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
---

name: 🏗 Enhancement Proposal
about: Proposals for code cleanup, refactor and improvements in general
---

## 🏗 Enhancement Proposal

<!--- A clear and concise description for your idea --->

### Pitch

<!--- How will this refactor improve contributors' lives? Input as many details as possible! --->

### Platforms affected (mark all that apply)
- [ ] :iphone: iOS
- [ ] :robot: Android
- [ ] :checkered_flag: WPF
- [ ] :earth_americas: UWP
- [ ] :apple: MacOS
- [ ] :tv: tvOS
- [ ] :monkey: Xamarin.Forms
13 changes: 13 additions & 0 deletions .github/ISSUE_TEMPLATE/e-question.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
---

name: 💬 Questions and Help
about: If you have questions, please use this for support
---

## 💬 Questions and Help

For questions or help we recommend checking:

- The [Xamarin tag in Stack Overflow](https://stackoverflow.com/questions/tagged/xamarin)
- The [General slack channel in the Xamarin Slack](https://xamarinchat.herokuapp.com/)
- Ask your question in the [Xamarin Forums](https://forums.xamarin.com/)
24 changes: 24 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
### :sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)


### :arrow_heading_down: What is the current behavior?


### :new: What is the new behavior (if this is a feature change)?


### :boom: Does this PR introduce a breaking change?


### :bug: Recommendations for testing


### :memo: Links to relevant issues/docs


### :thinking: Checklist before submitting

- [ ] All projects build
- [ ] Follows style guide lines
- [ ] Relevant documentation was updated
- [ ] Rebased onto current develop
5 changes: 5 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ build/
bld/
[Bb]in/
[Oo]bj/
.vscode/

# Visual Studo 2015 cache/options directory
.vs/
Expand Down Expand Up @@ -253,6 +254,10 @@ tools/*
!tools/packages.config
artifacts/
*.nupkg
*.binlog

#linting
.sonarqube/

# dotnet tools
.store/
74 changes: 74 additions & 0 deletions CODE_OF_CONDUCT.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
# Contributor Covenant Code of Conduct

## Our Pledge

In the interest of fostering an open and welcoming environment, we as
contributors and maintainers pledge to making participation in our project and
our community a harassment-free experience for everyone, regardless of age, body
size, disability, ethnicity, gender identity and expression, level of experience,
nationality, personal appearance, race, religion, or sexual identity and
orientation.

## Our Standards

Examples of behavior that contributes to creating a positive environment
include:

* Using welcoming and inclusive language
* Being respectful of differing viewpoints and experiences
* Gracefully accepting constructive criticism
* Focusing on what is best for the community
* Showing empathy towards other community members

Examples of unacceptable behavior by participants include:

* The use of sexualized language or imagery and unwelcome sexual attention or
advances
* Trolling, insulting/derogatory comments, and personal or political attacks
* Public or private harassment
* Publishing others' private information, such as a physical or electronic
address, without explicit permission
* Other conduct which could reasonably be considered inappropriate in a
professional setting

## Our Responsibilities

Project maintainers are responsible for clarifying the standards of acceptable
behavior and are expected to take appropriate and fair corrective action in
response to any instances of unacceptable behavior.

Project maintainers have the right and responsibility to remove, edit, or
reject comments, commits, code, wiki edits, issues, and other contributions
that are not aligned to this Code of Conduct, or to ban temporarily or
permanently any contributor for other behaviors that they deem inappropriate,
threatening, offensive, or harmful.

## Scope

This Code of Conduct applies both within project spaces and in public spaces
when an individual is representing the project or its community. Examples of
representing a project or community include using an official project e-mail
address, posting via an official social media account, or acting as an appointed
representative at an online or offline event. Representation of a project may be
further defined and clarified by project maintainers.

## Enforcement

Instances of abusive, harassing, or otherwise unacceptable behavior may be
reported by contacting the project team at [mvvmcross@gmail.com](mailto:mvvmcross@gmail). All
complaints will be reviewed and investigated and will result in a response that
is deemed necessary and appropriate to the circumstances. The project team is
obligated to maintain confidentiality with regard to the reporter of an incident.
Further details of specific enforcement policies may be posted separately.

Project maintainers who do not follow or enforce the Code of Conduct in good
faith may face temporary or permanent repercussions as determined by other
members of the project's leadership.

## Attribution

This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4,
available at [http://contributor-covenant.org/version/1/4][version]

[homepage]: http://contributor-covenant.org
[version]: http://contributor-covenant.org/version/1/4/
20 changes: 20 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# Contributing

## Finding an issue to work on

If you'd like to work on something that isn't in a current issue, especially if it would be a big change, please open a new issue for discussion!

## Setting up a development environment

First, you'll need git to fork and clone the repo. [GitHub has help pages about setting
up git](https://help.github.com/articles/set-up-git/), and once you've done
that, you should be able to clone the repo and change into the repo's directory
from your terminal:

```
git clone https://github.com/{YourFork}/XamarinMediaManager.git
```

If you are using SourceTree or another kind of visual git application, enter the url to your fork in the add new repository field.

After you are done pull the develop branch, and open `MediaManager.sln` in Visual Studio to get started.
100 changes: 80 additions & 20 deletions Directory.build.props
Original file line number Diff line number Diff line change
@@ -1,34 +1,94 @@
<Project>
<PropertyGroup>
<Copyright>Jack Dehlin, Martijn van Dijk</Copyright>
<PackageLicenseUrl>https://opensource.org/licenses/Apache-2.0</PackageLicenseUrl>
<PackageProjectUrl>https://github.com/jdehlin/Xamarin-Sidebar</PackageProjectUrl>
<PackageIconUrl>https://raw.githubusercontent.com/jdehlin/Xamarin-Sidebar/master/icon_sidebarnavigation.png</PackageIconUrl>
<Authors>Jack Dehlin, Martijn van Dijk</Authors>
<Owners>Jack Dehlin;martijn00</Owners>
<PackageTags>xamarin Xamarin.iOS10 Sidebar iOS Navigation hamburger menu</PackageTags>
<Copyright>Copyright (c) Martijn van Dijk, Jack Dehlin</Copyright>
<PackageLicenseExpression>Apache-2.0</PackageLicenseExpression>
<PackageProjectUrl>https://github.com/Baseflow/Xamarin-Sidebar</PackageProjectUrl>
<PackageIconUrl>https://raw.githubusercontent.com/Baseflow/Xamarin-Sidebar/develop/icon.png</PackageIconUrl>
<!--<PackageIcon>icon.png</PackageIcon>-->
<Authors>Martijn van Dijk, Jack Dehlin</Authors>
<Owners>Martijn van Dijk, Jack Dehlin</Owners>
<PackageTags>xamarin, android, plugin, MediaManager, media, audio, video</PackageTags>
<PackageReleaseNotes>https://github.com/Baseflow/Xamarin-Sidebar/releases</PackageReleaseNotes>
<PackageRequireLicenseAcceptance>false</PackageRequireLicenseAcceptance>
<RepositoryUrl>https://github.com/jdehlin/Xamarin-Sidebar</RepositoryUrl>

<RepositoryUrl>https://github.com/Baseflow/Xamarin-Sidebar</RepositoryUrl>
<RepositoryType>git</RepositoryType>
<Product>$(AssemblyName) ($(TargetFramework))</Product>
<NeutralLanguage>en</NeutralLanguage>
<Version>2.0.0</Version>
<Version>2.1.0</Version>
<Platform>AnyCPU</Platform>

<LangVersion>latest</LangVersion>
<NoWarn>$(NoWarn);1591;1701;1702;1705;VSX1000</NoWarn>
<GenerateDocumentationFile Condition=" '$(Configuration)' == 'Release' ">true</GenerateDocumentationFile>
<GeneratePackageOnBuild Condition=" '$(Configuration)' == 'Release' and '$(IsTestProject)' != 'true'">true</GeneratePackageOnBuild>
<!--<Nullable>enable</Nullable>-->
<LangVersion>8.0</LangVersion>
<NoWarn>$(NoWarn);1591;1701;1702;1705;VSX1000;NU1603</NoWarn>

<IsTestProject>$(MSBuildProjectName.Contains('UnitTest'))</IsTestProject>
<IsLibraryProject>$(MSBuildProjectName.Contains('MediaManager'))</IsLibraryProject>

<Platform>AnyCPU</Platform>
<DisableExtraReferences>true</DisableExtraReferences>
</PropertyGroup>

<PropertyGroup Condition=" '$(Configuration)' == 'Release' ">
<DesignTimeBuild>false</DesignTimeBuild>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<GeneratePackageOnBuild Condition=" '$(IsTestProject)' != 'true'">true</GeneratePackageOnBuild>
<DebugType>portable</DebugType>
<DebugSymbols>true</DebugSymbols>
</PropertyGroup>

<PropertyGroup Condition=" '$(Configuration)' == 'Debug' ">
<DebugType>full</DebugType>
<IsTestProject>$(MSBuildProjectName.Contains('UnitTest'))</IsTestProject>
<DebugSymbols>true</DebugSymbols>
</PropertyGroup>

<PropertyGroup Condition=" '$(Configuration)' == 'Release' And '$(OS)' == 'Windows_NT' ">
<!--<IncludeSymbols>true</IncludeSymbols>
<SymbolPackageFormat>snupkg</SymbolPackageFormat>-->

<PublishRepositoryUrl>true</PublishRepositoryUrl>
<EmbedUntrackedSources>true</EmbedUntrackedSources>
<AllowedOutputExtensionsInPackageBuildOutputFolder>$(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb</AllowedOutputExtensionsInPackageBuildOutputFolder>
</PropertyGroup>

<ItemGroup Condition="'$(IsLibraryProject)' == 'true'">
<None Include="$(MSBuildThisFileDirectory)\LICENSE" Pack="true" PackagePath="\" />
<None Include="$(MSBuildThisFileDirectory)\icon.png" Pack="true" PackagePath="\" />
</ItemGroup>

<ItemGroup Condition="'$(IsTestProject)' != 'true' and '$(SourceLinkEnabled)' != 'false' and '$(IsLibraryProject)' == 'true'">
<PackageReference Include="SourceLink.Create.CommandLine" Version="2.8.3" PrivateAssets="All" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="All" />
</ItemGroup>

<PropertyGroup Condition=" '$(Configuration)' == 'Debug' ">
<TargetsToBuild>All</TargetsToBuild>
<!--<TargetsToBuild>Android</TargetsToBuild>-->
<!--<TargetsToBuild>Uap</TargetsToBuild>-->
<!--<TargetsToBuild>iOS</TargetsToBuild>-->
<!--<TargetsToBuild>Apple</TargetsToBuild>-->
</PropertyGroup>

<PropertyGroup Condition=" '$(Configuration)' != 'Debug' ">
<TargetsToBuild>All</TargetsToBuild>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="MSBuild.Sdk.Extras" Version="1.2.2" PrivateAssets="All" />
<PackageReference Include="Roslynator.Analyzers" Version="2.3.0">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="AsyncFixer" Version="1.1.6">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<!--<PackageReference Include="IDisposableAnalyzers" Version="3.3.1">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>-->
<PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="2.9.8">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
</ItemGroup>

<ItemGroup Condition="'$(IsTestProject)' != 'true' and '$(SourceLinkEnabled)' != 'false' ">
<PackageReference Include="SourceLink.Create.CommandLine" Version="2.8.0" PrivateAssets="All" />
</ItemGroup>
</Project>
</Project>
Loading

0 comments on commit e13e3ad

Please sign in to comment.