Skip to content

Commit

Permalink
Merge branch 'main' into fix/1174-background-refresh-status
Browse files Browse the repository at this point in the history
  • Loading branch information
ened committed Feb 12, 2024
2 parents 8240470 + 669aff8 commit c4e9274
Show file tree
Hide file tree
Showing 89 changed files with 1,222 additions and 630 deletions.
13 changes: 12 additions & 1 deletion .github/workflows/permission_handler.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,11 @@ jobs:
name: App facing package

# The type of runner that the job will run on
runs-on: macos-latest
#
# TODO(mvanbeusekom): Manually set to macOS 13 to support Xcode 15 and iOS 17 SDKs.
# Currently `macos-latest` is based on macOS 12 and doesn't support iOS 17 SDK. This
# should be moved back to `macos-latest` when GitHub Actions images are updated.
runs-on: macos-13

env:
source-directory: ./permission_handler
Expand All @@ -33,6 +37,13 @@ jobs:
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
- uses: actions/checkout@v3

# Override current Xcode version with version 15.0.1.
#
# TODO(mvanbeusekom): Remove when the macos-latest image supports version 15.0.1
# out of the box (see https://github.com/actions/runner-images/blob/main/README.md).
- name: Select Xcode version
run: sudo xcode-select -s '/Applications/Xcode_15.0.1.app/Contents/Developer'

# Make sure JAVA version 17 is installed on build agent.
- uses: actions/setup-java@v3
with:
Expand Down
17 changes: 14 additions & 3 deletions .github/workflows/permission_handler_apple.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,11 @@ jobs:
name: Apple platform package

# The type of runner that the job will run on
runs-on: macos-latest
#
# TODO(mvanbeusekom): Manually set to macOS 13 to support Xcode 15 and iOS 17 SDKs.
# Currently `macos-latest` is based on macOS 12 and doesn't support iOS 17 SDK. This
# should be moved back to `macos-latest` when GitHub Actions images are updated.
runs-on: macos-13

env:
source-directory: ./permission_handler_apple
Expand All @@ -32,6 +36,13 @@ jobs:
steps:
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
- uses: actions/checkout@v3

# Override current Xcode version with version 15.0.1.
#
# TODO(mvanbeusekom): Remove when the macos-latest image supports version 15.0.1
# out of the box (see https://github.com/actions/runner-images/blob/main/README.md).
- name: Select Xcode version
run: sudo xcode-select -s '/Applications/Xcode_15.0.1.app/Contents/Developer'

# Make sure the stable version of Flutter is available
- uses: subosito/flutter-action@v2
Expand All @@ -54,7 +65,7 @@ jobs:
working-directory: ${{env.source-directory}}

# Build iOS version of the example App
- name: Run Android build
- name: Run iOS build
run: flutter build ios --no-codesign --release
working-directory: ${{env.example-directory}}


16 changes: 8 additions & 8 deletions CODE_OF_CONDUCT.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
## Our Pledge

In the interest of fostering an open and welcoming environment, we as
contributors and maintainers pledge to making participation in our project and
contributors and maintainers pledge to participate in our project and
our community a harassment-free experience for everyone, regardless of age, body
size, disability, ethnicity, gender identity and expression, level of experience,
nationality, personal appearance, race, religion, or sexual identity and
Expand All @@ -23,12 +23,12 @@ include:
Examples of unacceptable behavior by participants include:

* The use of sexualized language or imagery and unwelcome sexual attention or
advances
advances
* Trolling, insulting/derogatory comments, and personal or political attacks
* Public or private harassment
* Publishing others' private information, such as a physical or electronic
* Publishing others' private information, such as physical or electronic
address, without explicit permission
* Other conduct which could reasonably be considered inappropriate in a
* Other conduct that could reasonably be considered inappropriate in a
professional setting

## Our Responsibilities
Expand All @@ -45,8 +45,8 @@ threatening, offensive, or harmful.

## Scope

This Code of Conduct applies both within project spaces and in public spaces
when an individual is representing the project or its community. Examples of
This Code of Conduct applies both within and in public spaces
when an individual represents the project or its community. Examples of
representing a project or community include using an official project e-mail
address, posting via an official social media account, or acting as an appointed
representative at an online or offline event. Representation of a project may be
Expand All @@ -59,10 +59,10 @@ reported by contacting the project team at [hello@baseflow.com](mailto:hello@bas
complaints will be reviewed and investigated and will result in a response that
is deemed necessary and appropriate to the circumstances. The project team is
obligated to maintain confidentiality with regard to the reporter of an incident.
Further details of specific enforcement policies may be posted separately.
You can post more details of specific enforcement policies separately.

Project maintainers who do not follow or enforce the Code of Conduct in good
faith may face temporary or permanent repercussions as determined by other
Faith may face temporary or permanent repercussions as determined by other
members of the project's leadership.

## Attribution
Expand Down
65 changes: 30 additions & 35 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,49 +1,44 @@
Contributing to the Flutter Permission handler plugin
=============================================
# Contributing to the Flutter Permission handler plugin

What you will need
------------------
## What you will need

* A Linux, Mac OS X, or Windows machine (note: to run and compile iOS specific parts you'll need access to a Mac OS X machine);
* git (used for source version control, installation instruction can be found [here](https://git-scm.com/));
* The Flutter SDK (installation instructions can be found [here](https://flutter.io/get-started/install/));
* A personal GitHub account (if you don't have one, you can sign-up for free [here](https://github.com/))
* A Linux, Mac OS X, or Windows machine (note: to run and compile iOS-specific parts you'll need access to a Mac OS X machine);
* git (used for source version control, installation instructions can be found [here](https://git-scm.com/));
* The Flutter SDK (installation instructions can be found [here](https://flutter.io/get-started/install/));
* A personal GitHub account (if you don't have one, you can sign up for free [here](https://github.com/))

Setting up your development environment
---------------------------------------
## Setting up your development environment

* Fork `https://github.com/Baseflow/flutter-permission-handler` into your own GitHub account. If you already have a fork and moving to a new computer, make sure you update you fork.
* If you haven't configured your machine with an SSH key that's known to github, then
follow [GitHub's directions](https://help.github.com/articles/generating-ssh-keys/)
to generate an SSH key.
* Clone your forked repo on your local development machine: `git clone git@github.com:<your_name_here>/flutter-permission-handler.git`
* Change into the `flutter-permission-handler` directory: `cd flutter-permission-handler`
* Add an upstream to the original repo, so that fetch from the master repository and not your clone: `git remote add upstream git@github.com:Baseflow/flutter-permission-handler.git`
* Fork `https://github.com/Baseflow/flutter-permission-handler` into your own GitHub account. If you already have a fork and moving to a new computer, make sure you update your fork.
* If you haven't configured your machine with an SSH key that's known to GitHub, then
follow [GitHub's directions](https://help.github.com/articles/generating-ssh-keys/)
to generate an SSH key.
* Clone your forked repo on your local development machine: `git clone git@github.com:<your_name_here>/flutter-permission-handler.git`
* Change into the `flutter-permission-handler` directory: `cd flutter-permission-handler`
* Add an upstream to the original repo, so that fetches from the master repository and not your clone: `git remote add upstream git@github.com:Baseflow/flutter-permission-handler.git`

Running the example project
---------------------------
## Running the example project

* Change into the example directory: `cd example`
* Run the App: `flutter run`
* Change into the example directory: `cd example`
* Run the App: `flutter run`

Contribute
----------
## Contribute

We really appreciate contributions via GitHub pull requests. To contribute take the following steps:

* Make sure you are up to date with the latest code on the master:
* `git fetch upstream`
* `git checkout upstream/develop -b <name_of_your_branch>`
* Apply your changes
* Verify your changes and fix potential warnings/ errors:
* Check formatting: `flutter format .`
* Run static analyses: `flutter analyze`
* Run unit-tests: `flutter test`
* Commit your changes: `git commit -am "<your informative commit message>"`
* Push changes to your fork: `git push origin <name_of_your_branch>`
* Make sure you are up to date with the latest code on the master:
* `git fetch upstream`
* `git checkout upstream/develop -b <name_of_your_branch>`
* Apply your changes
* Verify your changes and fix potential warnings/ errors:
* Check formatting: `flutter format .`
* Run static analyses: `flutter analyze`
* Run unit-tests: `flutter test`
* Commit your changes: `git commit -am "<your informative commit message>"`
* Push changes to your fork: `git push origin <name_of_your_branch>`

Send us your pull request:

* Go to `https://github.com/Baseflow/flutter-permission-handler` and click the "Compare & pull request" button.
* Go to `https://github.com/Baseflow/flutter-permission-handler` and click the "Compare & pull request" button.

Please make sure you solved all warnings and errors reported by the static code analyses and that you fill in the full pull request template. Failing to do so will result in us asking you to fix it.
Please make sure you solved all warnings and errors reported by the static code analyses and that you fill in the full pull request template. Failing to do so will result in us asking you to fix it.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
The Flutter permission_handler plugin is build following the federated plugin architecture. A detailed explanation of the federated plugin concept can be found in the [Flutter documentation](https://flutter.dev/docs/development/packages-and-plugins/developing-packages#federated-plugins). This means the permission_handler plugin is separated into the following packages:

1. [`permission_handler`][1]: the app facing package. This is the package users depend on to use the plugin in their project. For details on how to use the `permission_handler` plugin you can refer to its [README.md][2] file. At this moment the Android and iOS platform implementations are also part of this package. Additional platform support will be added in their own individual "platform package(s)".
2. [`permission_handler_platform_interface`][3]: this packages declares the interface which all platform packages must implement to support the app-facing package. Instructions on how to implement a platform packages can be found int the [README.md][4] of the `permission_handler_platform_interface` package.
2. [`permission_handler_platform_interface`][3]: this packages declares the interface which all platform packages must implement to support the app-facing package. Instructions on how to implement a platform packages can be found in the [README.md][4] of the `permission_handler_platform_interface` package.

[1]: https://pub.dev/packages/permission_handler
[2]: ./permission_handler/README.md
Expand Down
Loading

0 comments on commit c4e9274

Please sign in to comment.