Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #461

Closed
wants to merge 1 commit into from
Closed

Update dependencies #461

wants to merge 1 commit into from

Conversation

Zazo032
Copy link
Contributor

@Zazo032 Zazo032 commented Sep 10, 2020

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

This rolls minimum Dart SDK to the bundled with Flutter's latest stable version. Also, bumps pedantic and octo_image to latest versions. The update of octo_image is required for placeholders to not be wrongly placed.

💥 Does this PR introduce a breaking change?

From octo_image:

[0.3.0] - 2020-09-07 
Fixed bug when fitting placeholders or error widgets.
BREAKING: Doesn't automatically center placeholders and error widgets anymore.

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines (code style guide)
  • Relevant documentation was updated
  • Rebased onto current develop

This rolls minimum Dart SDK to the bundled with Flutter's latest stable version. Also, bumps `pedantic` and `octo_image` to latest versions.
@renefloor
Copy link
Contributor

Thanks, I just wanted to update the dependencies.
IMO it is not needed to increase the minimum version of Flutter to 1.20.3, for this package 1.20.0 is just fine right?
Where can you find the dart versions shipped with the flutter sdk?

@Zazo032
Copy link
Contributor Author

Zazo032 commented Sep 10, 2020

It's OK if 1.20.0 is the minimum version, there are 3 hotfix releases that fix some bugs, I can revert back to 1.20.0. I did set 1.20.3 as it's the version you currently get when you run flutter channel stable, and you can check the bundled Dart SDK version by running dart --version or flutter --version. Latest stable Dart SDK is 2.9.3, but that one didn't make it to Flutter: flutter/engine#20838

@renefloor
Copy link
Contributor

Yes if you can revert it that would be good. I don't want people to force a Flutter update when it is not needed for that package. It is mainly 1.20 because it is really incompatible with 1.17.

@Zazo032 Zazo032 closed this Sep 10, 2020
@Zazo032
Copy link
Contributor Author

Zazo032 commented Sep 10, 2020

Re-opened in #464 with some analyzer changes that may help #463

@Zazo032 Zazo032 deleted the patch-1 branch September 10, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants