Skip to content

Commit

Permalink
lib/helpers: fix all_groups()
Browse files Browse the repository at this point in the history
- Don't write to disk, just pipe.
- Don't loop, just do all functions.

Performance of old implementation on my system:
```
real    0m9.996s
user    0m5.318s
sys     0m9.126s
```

Performance of new implementation on my system:
```
real    0m0.052s
user    0m0.069s
sys     0m0.025s
```
  • Loading branch information
gaelicWizard committed Sep 23, 2021
1 parent 5e5d0d4 commit 71e3afc
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions lib/helpers.bash
Original file line number Diff line number Diff line change
Expand Up @@ -811,13 +811,7 @@ function all_groups() {
about 'displays all unique metadata groups'
group 'lib'

local func file
file=$(mktemp -t composure.XXXX)
for func in $(_typeset_functions); do
declare -f "$func" | metafor group >> "$file"
done
sort -u "$file"
rm "$file"
declare -f | metafor group | sort -u
}

if ! _command_exists pathmunge; then
Expand Down

0 comments on commit 71e3afc

Please sign in to comment.