Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix knife completion load time (and pre-commit compliance) #1708

Merged
merged 6 commits into from
Dec 9, 2020

Conversation

ira-bv
Copy link
Contributor

@ira-bv ira-bv commented Nov 8, 2020

No description provided.

@cornfeedhobo
Copy link
Member

cornfeedhobo commented Nov 8, 2020

Edit: First and foremost, thank you for your contribution!!

I'm going to see what others think about merging this. I'm not sure we want to embed more work, but I looked around I can't find any completions that chef includes.

If we do decide to include this, it should at least include a note about the repo it comes from.

@ira-bv
Copy link
Contributor Author

ira-bv commented Nov 8, 2020

makes sense. I'll add a remark with a link.

@NoahGorny
Copy link
Member

Great job @ira-bv !
Please add the file to 'clean_files.txt' in order to enforce linting of the file in the future!

@ira-bv
Copy link
Contributor Author

ira-bv commented Nov 12, 2020

now that I know this file is a thing, I'll add it once I'm done cleaning up 👍

* master:
  github: Add no-response bot
  Update contribution.rst
  Add cargo completion
  Add completion for pipx. (Bash-it#1719)
  Add github action to replace travis
  Address some comments.
  Add in_toolbox prompt to powerline themes
  Update atomic.theme.bash
  Add rustup completion to clean_files.txt
  Add rustup completion
  Move README to be under docs/
  docs: Transition md files to support new rtd format
  pre-commit: Exclude docs _build folder
  Add aliases for GIT-SVN (rebase and dcommit)
@seefood
Copy link
Contributor

seefood commented Dec 8, 2020

@NoahGorny merge away...

Copy link
Member

@cornfeedhobo cornfeedhobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

@NoahGorny
Copy link
Member

Great job @ira-bv and @cornfeedhobo !

Someday we will transform all vendored files into something different, as it creates licensing issues, but currently that's what we got

@NoahGorny NoahGorny merged commit 9b837b4 into Bash-it:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants