Skip to content

Conversation

@georgettica
Copy link
Contributor

I don't use it very often and am fine with not putting it in, but worth pushing it out there

@NoahGorny
Copy link
Member

hey @georgettica
Seems like you had trailing whitespaces in your code, fix it up and I will happily merge this.

PS: Would you like to clean this alias file as part of #1696?
This would be great 😄

@georgettica
Copy link
Contributor Author

I can do that, but not sure how to run the pre-commit check

@NoahGorny
Copy link
Member

You need to add your file to clean_files.txt and run lint_cleam_files.sh

We will add docs about it asap so it will be clearer

@georgettica
Copy link
Contributor Author

I was actually looking at the pt you referenced me in.
Will run it

@georgettica
Copy link
Contributor Author

georgettica commented Dec 16, 2020

@NoahGorny

$ lint_clean_files.sh
./lint_clean_files.sh: line 23: pre-commit: command not found

@NoahGorny
Copy link
Member

@georgettica seems like you need to install pre-commit. Usually this can be achieved by running python -m pip install pre-commit

Also make sure to install shfmt, which is the formatter we use in Bash-it

@georgettica
Copy link
Contributor Author

Okidok.
Thanks for pointing it out :))

@georgettica
Copy link
Contributor Author

@NoahGorny added what you requested now :) hope it's good enough

@NoahGorny
Copy link
Member

@georgettica amazing work! Thanks for your contribution ❤️

Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small comment, otherwise looks great

Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @georgettica !

@NoahGorny NoahGorny merged commit 1d4b325 into Bash-it:master Dec 28, 2020
@georgettica
Copy link
Contributor Author

Yay!

@georgettica georgettica deleted the patch-2 branch December 29, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants