Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sdkman bash completion to the list of clean files #1775

Merged
merged 2 commits into from
Jan 8, 2021

Conversation

marcospereira
Copy link
Contributor

Description

Add sdkman bash completion to the list of clean files, fix the issues reported by shellcheck, and reformat the code with shfmt.

Motivation and Context

Follow up to #1763 as suggested by @NoahGorny.

How Has This Been Tested?

Manually, the same way #1763 was tested before. See bash version there.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code clean up

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

Copy link
Contributor

@davidpfarrell davidpfarrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using "Hide whitespace changes" to review the diffs, and everything looks like I would expect.

Thanks!

Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @marcospereira!

@NoahGorny NoahGorny merged commit 3fce1ff into Bash-it:master Jan 8, 2021
@marcospereira marcospereira deleted the cleanup/sdkman branch January 13, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants