Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed existing completion and added conditional completion #1778

Merged
merged 1 commit into from
Jan 13, 2021

Conversation

tbhaxor
Copy link
Contributor

@tbhaxor tbhaxor commented Jan 9, 2021

Description

Fixed the vue completions

Motivation and Context

How Has This Been Tested?

Yes, by sourceing the completion file :P

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh. (wait for another PR)
  • I have added tests to cover my changes, and all the new and existing tests pass.

Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never used vue before, but seems like a very clean and neat PR. Well done @tbhaxor!

I will let others take a look as well before merging, and also remind you that you are welcome to open a followup cleanup PR 😄

@NoahGorny NoahGorny merged commit a0ea33d into Bash-it:master Jan 13, 2021
@tbhaxor tbhaxor deleted the bugfix/vue-routes branch January 23, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants