-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean b* themes #1790
Clean b* themes #1790
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great!
Thank you @BarbUk !!
I left a comment, that require you to change some things back to the way they were, but otherwise it looks really good 😄
@cornfeedhobo made a good argument in #1791 (comment), we should not change the code for COMPREPLY array when we know that the string used is safe. The warning is now disabled only for the appropriate lines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I will let other folks chime in if they want, but well done @BarbUk !
Thank you for helping us make a big step into making this project a cleaner place 😄
I use bash-it since ~2011, it's great to give a little time to the project :) |
Description
Clean and lint b* themes
Motivation and Context
#1696
How Has This Been Tested?
Tested all themes before and after changes.
1 error was detected, resulting in an other PR: #1789
Types of changes
Checklist:
clean_files.txt
and formatted it usinglint_clean_files.sh
.