Disable keep-padding option in shfmt #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Has some serious bugs and not really needed Also fixed all files that need to be changed after this
Comment on lines
-210
to
+213
| if ${SCM_GIT_USE_GITSTATUS} && _command_exists gitstatus_query && gitstatus_query && [[ "${VCS_STATUS_RESULT}" == "ok-sync" ]]; then # use faster gitstatus | ||
| SCM_GIT_GITSTATUS_RAN=true # use this in githelpers and below to choose gitstatus output | ||
| if ${SCM_GIT_USE_GITSTATUS} && _command_exists gitstatus_query && gitstatus_query && [[ "${VCS_STATUS_RESULT}" == "ok-sync" ]]; then | ||
| # we can use faster gitstatus | ||
| # use this variable in githelpers and below to choose gitstatus output | ||
| SCM_GIT_GITSTATUS_RAN=true |
There was a problem hiding this comment.
Was this change related to the keep-padding setting?
There was a problem hiding this comment.
Yes, as shfmt did a pretty wierd formatting to the comment, so I preferred to change it entirely
davidpfarrell
approved these changes
Jan 22, 2021
|
Same. And it sounds like mvdan doesn't want to support this feature anymore anyways. |
cornfeedhobo
approved these changes
Jan 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has some serious bugs and not really needed
Description
Disable the -kp option in shfmt by disabling it in our editorconfig
Also fixed all files that need to be changed after this
Motivation and Context
This was needed as -kp is buggy (mvdan/sh#652)
Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.