Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modern theme, added virtualenv name display, changed first bracket and second bracket #1812

Merged
merged 5 commits into from
Jan 26, 2021

Conversation

dot-1q
Copy link
Contributor

@dot-1q dot-1q commented Jan 22, 2021

Description

Changed the first brackets of the theme to show the username, and the second brackets to show the current working directory
Also added a function to show the name of the python virtualenv, when its being used.

Motivation and Context

Looks better, and the second bracket is actually used for something, because previously it was calling (battery_charge) and not working.
Having the name of the python virtualenv showing is useful information.

How Has This Been Tested?

No errors
Entering and leaving a virtualenv have the desired behaviour on the terminal.

Screenshots (if appropriate):

How it looks after the changes: https://imgur.com/3yQzH5m
(using Dracula terminal theme)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@NoahGorny
Copy link
Member

Hey @tiagobarros99, seems like a great change! Thanks!
It seems that you have some trailing spaces added in this PR, fix them and I think its ready 😄

On a side note, you are welcome to open a followup PR which is properly linting the file (by adding it to clean_files.txt and running lint_clean_files.sh

Let me know what you think!

@dot-1q
Copy link
Contributor Author

dot-1q commented Jan 23, 2021

Removed the trailing spaces, sorry about that!

On a side note, you are welcome to open a followup PR which is properly linting the file

Okay, will do!

Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Howdy @tiagobarros99, I left a couple more comments, but good job on addressing my other comments so fast! well done!

Also, no need to apologise, we all make mistakes, its part of life 😄
Thank you for contributing and thank you for helping us make Bash-it better 😃

themes/modern/modern.theme.bash Show resolved Hide resolved
themes/modern/modern.theme.bash Outdated Show resolved Hide resolved
themes/modern/modern.theme.bash Outdated Show resolved Hide resolved
Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @tiagobarros99 !
You also responded quickly- which helped me approve this PR much faster, good job 😄

Looking forward to a cleanup PR, where you add the file to clean_files.txt 😃

@dot-1q dot-1q mentioned this pull request Jan 24, 2021
8 tasks
@NoahGorny NoahGorny merged commit 2db806f into Bash-it:master Jan 26, 2021
@dot-1q dot-1q deleted the fix-modern-theme branch March 29, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants