use absolute paths instead of changing directory #1822
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR stops changing directories while reloading, which I'm calling a bug because it is completely different from my expectations and caused a lot of debugging confusion. I'm also labeling this as help-wanted because I'd like some people to test this manually since we don't really have integration tests yet, but I'm feeling pretty good about it.
Motivation and Context
While playing around with the *env plugins, I discovered that if I started a fresh shell from a directory with a
.*-version
file, the tools were still unable to figure out the set version, because we are changing the working directory while loading.How Has This Been Tested?
locally and with bats
Screenshots (if appropriate):
Types of changes
Checklist:
clean_files.txt
and formatted it usinglint_clean_files.sh
.