Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up pyenv plugin #1885

Merged
merged 1 commit into from
Sep 28, 2021
Merged

clean up pyenv plugin #1885

merged 1 commit into from
Sep 28, 2021

Conversation

cornfeedhobo
Copy link
Member

This commit cleans up the pyenv plugin to follow the newer conventions of the
other *env plugins, as well as addresses the changes made to pyenv for PATH
munging.

Motivation and Context

Fixes #1882

How Has This Been Tested?

locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment, looks great otherwise!

plugins/available/pyenv.plugin.bash Show resolved Hide resolved
@NoahGorny
Copy link
Member

@cornfeedhobo want to revisit this?

Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @cornfeedhobo

@NoahGorny
Copy link
Member

@cornfeedhobo fix the conflicts and I'll take another look 😄

This commit cleans up the pyenv plugin to follow the newer conventions of the
other *env plugins, as well as addresses the changes made to pyenv for PATH
munging.
@cornfeedhobo
Copy link
Member Author

cornfeedhobo commented Sep 28, 2021

@NoahGorny rebased and pushed. Sorry, I was leaving the merge to you, but I should have merged it once your review was finished. Thanks again.

@NoahGorny NoahGorny merged commit 008c2b3 into Bash-it:master Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest pyenv versions require different initialisation
2 participants