Don't set indent_size when using tabs
#1916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaelicWizard
force-pushed
the
EditorConfig
branch
from
bac8ca1
to
a5498be
Compare
When using tabs, `indent_size` should be set to `tab`, which is the default. Furthermore, `tab_width` (which is likely what was intended when `indent_size` was entered) should be left up to the user. If the user likes an 8-character indent, then let them. If they like 2-character indent size, then let them. Using tabs means that this all works normally for everyone, even if it's different on different screens.
gaelicWizard
force-pushed
the
EditorConfig
branch
from
a5498be
to
6ee4cb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
indent_sizeshould be set totab, andtab_widthshould be set to the desired indentation distance. However,tab_widthis a deeply personal religious conviction and should not be set by a shared community project.Motivation and Context
It's possible someone forces
tab_widthto 8 and then their editor may half-tab by using spaces ofindent_size...which is somehow worse than always using tabs or always using spaces...How Has This Been Tested?
I've never used
.editorconfigbefore, but I installed the TextMate plugin.Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.