Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Executable Bit #1935

Merged
merged 1 commit into from
Sep 20, 2021
Merged

Remove Executable Bit #1935

merged 1 commit into from
Sep 20, 2021

Conversation

gaelicWizard
Copy link
Contributor

Description

Remove the executable "permission" bit from Git.

Motivation and Context

The pre-commit hook prohibits the executable bit from being set on files which are not intended to be run directly, so just remove it from all of them.

NOTE: this PR assumes that my basenamed (#1926) and pwd (#1927) branches have been merged.

How Has This Been Tested?

All tests pass.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@gaelicWizard
Copy link
Contributor Author

After pwd and basenamed, there's literally zero content changes in this PR so I'm just going to mark it ready-to-review

@gaelicWizard gaelicWizard marked this pull request as ready for review September 18, 2021 07:31
@gaelicWizard gaelicWizard changed the title DRAFT: Remove Executable Bit Remove Executable Bit Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants