DRAFT: Update themes to use new Automatic History Management #1951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaelicWizard
changed the title
gaelicWizard
force-pushed
the
history_themes
branch
from
0ae7dcb
to
8220aa2
Compare
|
@davidpfarrell, this is "stacked" on my automatic history management PR, which has been approved, but I'd love to start getting feedback on this one pending that one getting merged. Do you think I should just remove all history management from themes rather than just adopting the new functions? I think that might require an update to the documentation too. |
gaelicWizard
force-pushed
the
history_themes
branch
2 times, most recently
from
edba5dd
to
4ae213a
Compare
3 tasks
6 tasks
gaelicWizard
force-pushed
the
history_themes
branch
13 times, most recently
from
34c9d79
to
95148bf
Compare
gaelicWizard
force-pushed
the
history_themes
branch
5 times, most recently
from
1c5a6d3
to
ec96c60
Compare
gaelicWizard
force-pushed
the
history_themes
branch
4 times, most recently
from
8ee61fd
to
455bbe2
Compare
gaelicWizard
force-pushed
the
history_themes
branch
from
455bbe2
to
52bac07
Compare
gaelicWizard
force-pushed
the
history_themes
branch
11 times, most recently
from
d698955
to
0e88fd0
Compare
gaelicWizard
force-pushed
the
history_themes
branch
from
0e88fd0
to
7825eb9
Compare
...so the plugin is friendly to variables already marked read-only.
...and hide errors relating to setting already-readonly variables. `plugin/history-eternal` does not need to force loading after `plugin/history` because both plugins will play nicely with read-only variables, and since we're overwritting and marking read-only then the intended result survives no matter which loads first. plugin/history-eternal: require Bash v4.3+ Unlimited history is only possible in _Bash_ version 4.3 and up
There's no need for these plugins to load after `plugin/history`. None of the history plugins depend upon each other loading before, after, or at all.
Two new functions `_bash-it-history-auto-save()` and `_bash-it-history-auto-load()`, which append new history to disk and load new history from disk, respectively. See Bash-it#1595 for discussion.
First pass to use _Bash It_'s automatic history management.
Use `preexec` and `$HISTCONTROL` to configure _Bash It_'s automatic history management feature.
Use `preexec` and `$HISTCONTROL` to configure _Bash It_'s automatic history management feature.
Use `preexec` and `$HISTCONTROL` to configure _Bash It_'s automatic history management feature.
Use `preexec` and `$HISTCONTROL` to configure _Bash It_'s automatic history management feature.
Use `preexec` and `$HISTCONTROL` to configure _Bash It_'s automatic history management feature.
Use `preexec` and `$HISTCONTROL` to configure _Bash It_'s automatic history management feature.
Use `preexec` and `$HISTCONTROL` to configure _Bash It_'s automatic history management feature.
Use `preexec` and `$HISTCONTROL` to configure _Bash It_'s automatic history management feature.
gaelicWizard
force-pushed
the
history_themes
branch
from
7825eb9
to
ee65fd8
Compare
gaelicWizard
changed the title
|
@cornfeedhobo, would you suggest just yanking all history-related tomfoolery from themes or to update them to interact with the new automatic history management? Long term, I vote for themes-don't-touch-history, but I'm conflicted about short-term. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This follows up on my
history(#1940) branch to adopt the two new functions in all themes which had already included history management.Closes #1595.
Motivation and Context
This PR adopts the new functions from #1940 and removes all use of the old function
_save-and-reload-history(), but does not remove the function yet (in case anyone is using it somewhere out of tree...for the time being).A future PR should remove all history-related activities from all the themes. I didn't do that here as I want to be as minimally-invasive as possible in this PR. At that time, it will need to be determined how to account for users who have not enabled
plugin/historybut who use a theme which triggershistory -a...their history would after that future PR suddenly stop saving the way they're used to.How Has This Been Tested?
All tests pass.
Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.