Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin(dirs): remove shopt -s cdable_vars #1992

Merged
merged 1 commit into from
Dec 18, 2021

Conversation

davidpfarrell
Copy link
Contributor

Removes shopt setings from dirs plugin

Description

Remove thes shopt -s cdable_vars setting from the dirs plugin.

Motivation and Context

I decided that I no-longer wanted cdable_vars enabled as I have too many environment variables and they were constantly getting in the way of tab-completing cd.

After removing the option from the my local bash config (I had it explicitly enabled), I discovered that it was STILL enabled when launching a new terminal.

I tracked it down to this plugin.

As much as possible, shopt settings should be left to the user.

Additionally, this plugin does not require the cdable_vars be enabled.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Marking as Breaking Change since some users may have picked up the setting from this plugin and may not realize why its missing after their next update.

Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@NoahGorny NoahGorny merged commit 8edbdf9 into Bash-it:master Dec 18, 2021
@davidpfarrell davidpfarrell deleted the dirs branch May 8, 2022 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants