plugin(dirs): remove shopt -s cdable_vars #1992
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
shopt
setings fromdirs
pluginDescription
Remove thes
shopt -s cdable_vars
setting from thedirs
plugin.Motivation and Context
I decided that I no-longer wanted
cdable_vars
enabled as I have too many environment variables and they were constantly getting in the way of tab-completingcd
.After removing the option from the my local bash config (I had it explicitly enabled), I discovered that it was STILL enabled when launching a new terminal.
I tracked it down to this plugin.
As much as possible,
shopt
settings should be left to the user.Additionally, this plugin does not require the cdable_vars be enabled.
Types of changes
Marking as Breaking Change since some users may have picked up the setting from this plugin and may not realize why its missing after their next update.