Revert most of "Fix linting errors that snuck in." #2000
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reverts most of commit 2c8ee40.
Motivation and Context
source-path
directive indicates this is correct usage. We'resource
ing thebash-preexec.sh
file from inside thevendor/github.com/rcaloras/bash-preexec
directory. If we used thesource
directive, then the full complete path to the file itself would need to be specified.disable=1090
todisable=SC1090
and remove duplicate lines since thisshellcheck
directive will apply to the entire if-ladder.SC2154
is almost never appropriate. In this case, several_git_bash_completion*
variables are expressly assigned in this file, so there is no "unknown" to ignore.Aside: the
${!_git_bash_completion@}
construct will expand to all variables starting with the prefix_git_bash_completion
, so this line is just a shorthand way to clear all our variables concisely without forgetting any.Types of changes
Checklist:
clean_files.txt
and formatted it usinglint_clean_files.sh
.