Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin/nginx: cleanup #2011

Merged
merged 1 commit into from
Jan 8, 2022
Merged

plugin/nginx: cleanup #2011

merged 1 commit into from
Jan 8, 2022

Conversation

gaelicWizard
Copy link
Contributor

Description

Dont overwrite user-set variable, and quote path. Local some variables, shellcheck, shfmt

Motivation and Context

Just cleaning up.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@gaelicWizard gaelicWizard marked this pull request as ready for review December 31, 2021 23:41
NoahGorny
NoahGorny approved these changes Jan 3, 2022
View reviewed changes
Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @gaelicWizard

@gaelicWizard
plugin/nginx: cleanup
079652e 
Dont overwrite user-set variable, and quote path. Local some variables, `shellcheck`, `shfmt`
@NoahGorny NoahGorny merged commit 21e7c1f into Bash-it:master Jan 8, 2022
@gaelicWizard gaelicWizard deleted the plugin-nginx branch January 8, 2022 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoahGorny NoahGorny NoahGorny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaelicWizard @NoahGorny