Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update BATS #2030

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Update BATS #2030

merged 1 commit into from
Jan 24, 2022

Conversation

gaelicWizard
Copy link
Contributor

@gaelicWizard gaelicWizard commented Jan 10, 2022 •
edited
Loading

Description

Update the BATS submodules to the latest tags.

  • bats-core: v1.5.0

Closes #1633.

Motivation and Context

Just trying to get Bash It working in modern environments! If you don't know my motivation by now, I dunno what to tell you 😉

How Has This Been Tested?

Types of changes

  • Breaking change (BATS is getting stricter and stricter!)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@gaelicWizard
test_lib: update BATS to latest tag(s)
9291b46 
And fix any failing tests.
@gaelicWizard gaelicWizard marked this pull request as ready for review January 10, 2022 08:32
@gaelicWizard
Copy link
Contributor Author

I'd actually like to update to master as they have significantly improved the environment in which the tests run, even without running the tests in full strict mode, but I figured that they do have regular ongoing release tags so we should probably stick to those. But I'll PR as soon as they tag the next release!

NoahGorny
NoahGorny approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @gaelicWizard

@NoahGorny NoahGorny merged commit edc3679 into Bash-it:master Jan 24, 2022
@gaelicWizard gaelicWizard deleted the bats branch January 25, 2022 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoahGorny NoahGorny NoahGorny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Bats-core to v1.2.1
2 participants
@gaelicWizard @NoahGorny