Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to GitHub issue forms #2077

Merged
merged 5 commits into from Mar 4, 2022
Merged

Upgrade to GitHub issue forms #2077

merged 5 commits into from Mar 4, 2022

Conversation

EmilyGraceSeville7cf
Copy link
Contributor

@EmilyGraceSeville7cf EmilyGraceSeville7cf commented Feb 7, 2022

Description

Switch to GitHub issue forms from legacy issue templates.

Motivation and Context

It's easier create forms via .yml files because VS Code and such editors can suggest autocomplete for them. Also there are linters for YAML and that's good. ;)

How Has This Been Tested?

I've created a sample repo and tested these templates.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

EmilySeville7cfg added 3 commits February 7, 2022 10:43
@gaelicWizard
Copy link
Contributor

I think I'm in favor of this in general, but I think this raises some questions about what to actually put in the form. With a template, it can be edited during submission if some parts make more or less sense in context. With a form, if we require a field that just doesn't apply to a given situation then the submitter has to put some junk in there which then in turn encourages sticking junk in there to begin with and it kinda defeats its own purpose. Just thinking out loud...

@EmilyGraceSeville7cf
Copy link
Contributor Author

EmilyGraceSeville7cf commented Feb 7, 2022

We can use an extra field «Notes» at the bottom for this case (but it's hard to imagine for me). Where any content can be placed. The idea is standardize issue content as much as possible. 😊

Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @EmilySeville7cfg, this looks like a cool addition!
I agree with @gaelicWizard that there should be a room for general notes

.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
EmilySeville7cfg added 2 commits February 20, 2022 18:45
@EmilyGraceSeville7cf
Copy link
Contributor Author

Hi @EmilySeville7cfg, this looks like a cool addition! I agree with @gaelicWizard that there should be a room for general notes

Done. 👍🏻

@gaelicWizard
Copy link
Contributor

gaelicWizard commented Feb 20, 2022

I wouldn't add a link to Libera chat in there. There's literally nobody there, except one person who uses IRC and he's not actually there (just his account is logged in). Alsö, being IRC, there is no persistent chat. If someone asks a question and nobody answers immediately, then the question just disappears.

@EmilyGraceSeville7cf
Copy link
Contributor Author

What about to use GitHub Discussions or Telegram? 😺

@gaelicWizard
Copy link
Contributor

gaelicWizard commented Feb 23, 2022

Telegram, Facebook, Signal, iMessage, &c all have the same issue: they're only for people who are already there. My +1 is for GitHub Discussions since the one place we already are is exactly here, but that's out of scope for this PR. (#2078)

I was just whining that you added a link to somewhere that's not actually got help to get. 😃

Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @gaelicWizard what do you think?

@NoahGorny NoahGorny merged commit 6a53066 into Bash-it:master Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants