lib/log: //echo/printf

[gaelicWizard]

Description

• Replace echo -e with printf in _bash-it-log-message().
• local positional parameters to allow for defaults.
• Use new composure.sh feature to reduce load order dependency.
• Use if/then properly.
• Clean up use of $BASH_IT_LOG_PREFIX slightly (eliminate duplicate colons).

Motivation and Context

Misuse of &&/|| can cause unexpected return status, so I'm just fixing to use if/then wherever I see them. echo -e is unreliable and has differing behaviour in different contexts, such as in subshells and when xpg_echo is enabled. printf does exactly what it says on the tin. The parameter $message was leaking from every log function, so I local'd it. Alsö, local the rest of the parameters and fill in a default color, default log level, and strip duplicate colons from the message and level.

How Has This Been Tested?

Now that #1902 is merged, I can start a whole shell straight off master!! So, anyway, I have my $BASH_IT_LOG_LEVEL set to max in my ~/.bashrc so I see all the messages and everything still works.

Types of changes

• Bug fix (non-breaking change which fixes an issue)

Checklist:

• My code follows the code style of this project.
• If my change requires a change to the documentation, I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
• I have added tests to cover my changes, and all the new and existing tests pass.

[NoahGorny]

LGTM