Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test file path from the 7fcad6e commit #2108

Merged
merged 1 commit into from
Mar 6, 2022

Conversation

tbhaxor
Copy link
Contributor

@tbhaxor tbhaxor commented Mar 5, 2022

Description

In the commit 7fcad6e the file rename was done test/plugins/alias-completion.plugin.bats → test/completion/aliases.completion.bats. This PR resolve the file not found error caused while performing lint on the old file

For more context, check this build output

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix @tbhaxor
Weird that we didn't see it in the original pr

@gaelicWizard gaelicWizard merged commit db6fd42 into Bash-it:master Mar 6, 2022
@tbhaxor tbhaxor deleted the patch-3 branch March 6, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants