Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/command duration precision #2119

Merged
merged 2 commits into from
Mar 14, 2022

Conversation

BarbUk
Copy link
Contributor

@BarbUk BarbUk commented Mar 9, 2022

Description

Change back the precision of command duration to deciseconds instead of nanoseconds

Motivation and Context

The precision of command duration is not accurate with nanoseconds or microseconds.
Using deciseconds gave the best result when I initially developed this functionality.

Moreover, the current calculations are not valid:

deciseconds="$((10 - (command_start_deciseconds - current_time_deciseconds)))"

This can only be used accurately with deciseconds.

If anyone is interested, I can modify this PR to introduce a configuration giving user the choice of precision to use:

  • seconds only
  • deciseconds
  • microseconds
  • etc.

How Has This Been Tested?

Calculation have been verified and display has been tested with barbuk theme (cf screenshot).

Screenshots (if appropriate):

Before:
image

After:
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@BarbUk BarbUk force-pushed the fix/command_duration_precision branch from 37a300b to 634c1f8 Compare March 9, 2022 10:02
Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @BarbUk !

@NoahGorny NoahGorny merged commit d1b831a into Bash-it:master Mar 14, 2022
@gaelicWizard
Copy link
Contributor

Thanks @BarbUk!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants