Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin(dirs): Create backup file parent directory #2147

Merged
merged 1 commit into from
May 18, 2022

Conversation

davidpfarrell
Copy link
Contributor

@davidpfarrell davidpfarrell commented May 9, 2022

Fixes #2143

Creates parent directory for dirs plugin backup file.

Description

Adds a mkdir command to create the parent directory for the backup file before trying to touch the file itself.

Motivation and Context

Plugin currently assumes the parent directory exists and causes a failure with error msg during plugin initialization.

How Has This Been Tested?

Tested locally.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davidpfarrell !

@NoahGorny NoahGorny merged commit 03b3a97 into Bash-it:master May 18, 2022
@davidpfarrell davidpfarrell deleted the dirs-bks branch May 18, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Enabling dirs plugin throws touch errors on startup
2 participants