remove function wrapper around kubectl aliases #2166
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is minor house cleaning. I saw the function name and didn't like that it's name wasn't well scoped,
and further, I see no need for wrapping this logic with a function.
Thought for the future: maybe all alias loading should be wrapped in a callable with a predictable name?
e.g.
_bash_it_load_alias_<alias plugin name>
Motivation and Context
I don't like polluting the global namespace with poorly named functions
How Has This Been Tested?
See the test output.
Types of changes
Checklist:
clean_files.txt
and formatted it usinglint_clean_files.sh
.