Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Splinky configs #15

Closed
0xcharly opened this issue Jul 14, 2022 · 3 comments
Closed

Update Splinky configs #15

0xcharly opened this issue Jul 14, 2022 · 3 comments
Assignees

Comments

@0xcharly
Copy link
Collaborator

Pinout was adjusted in the latest revision to match the standard rp-2040-based boards pinout:

/* Key matrix configuration. */
#define MATRIX_ROW_PINS \
  { GP26, GP5, GP4, GP9 }
#define MATRIX_COL_PINS \
  { GP28, GP21, GP6, GP7, GP8 }
  
/* Handedness. */
#define MASTER_RIGHT
// To use the handedness pin, resistors need to be installed on the adapter PCB.
// If so, uncomment the following code, and undefine MASTER_RIGHT above.
// #define SPLIT_HAND_PIN GP13
// #define SPLIT_HAND_PIN_LOW_IS_LEFT // High -> right, Low -> left.

/* serial.c configuration (for split keyboard). */
#define SOFT_SERIAL_PIN GP1

/* RGB settings. */
#define RGB_DI_PIN GP0

/* SPI & PMW3360 settings. */
#define SPI_DRIVER SPID0
#define SPI_SCK_PIN GP22
#define SPI_MOSI_PIN GP23
#define SPI_MISO_PIN GP20
#define PMW3360_CS_PIN GP16

/* Reset. */
#define RP2040_BOOTLOADER_DOUBLE_TAP_RESET
#define RP2040_BOOTLOADER_DOUBLE_TAP_RESET_LED GP17
#define RP2040_BOOTLOADER_DOUBLE_TAP_RESET_TIMEOUT 1000U
@0xcharly
Copy link
Collaborator Author

Add a compile time flag to keep backward compatibility with the previous gen.

@0xcharly 0xcharly self-assigned this Jul 14, 2022
0xcharly pushed a commit that referenced this issue Aug 7, 2022
The pinout of the splinky changed between the last beta batch, and the
production one. This commit updates the keyboard definition to support
the new pinout by default, while offering backward compatibility.

Define `SPLINKY_BETA_PINOUT` to build the firmware with pre-production
pinout.

Fixes #15
0xcharly pushed a commit that referenced this issue Aug 7, 2022
The pinout of the splinky changed between the last beta batch, and the
production one. This commit updates the keyboard definition to support
the new pinout by default, while offering backward compatibility.

Define `SPLINKY_BETA_PINOUT` to build the firmware with pre-production
pinout.

Fixes #15
0xcharly pushed a commit that referenced this issue Aug 20, 2022
The pinout of the splinky changed between the last beta batch, and the
production one. This commit updates the keyboard definition to support
the new pinout by default, while offering backward compatibility.

Define `SPLINKY_BETA_PINOUT` to build the firmware with pre-production
pinout.

Fixes #15
@harmonicoscillator
Copy link

I have a 3x5 charybdis with beta splinkys and I'm trying to figure out how to properly set the compile-time flag SPLINKY_BETA_PINOUT in my keymap.

I am building on top of the bkb-develop branch. Adding #define SPLINKY_BETA_PINOUT to my keymap's config.h does NOT work, the non-beta pinout still gets picked. I'm not super familiar with the order of config-file loading in QMK, do I need to set that define somewhere else outside of my keymap config.h file?

For reference, I have my keymap in the folder qmk_firmware/keyboards/bastardkb/charybdis/3x5/keymaps/alex-miryoku/. I use the following compile command to generate the keymap:

qmk compile -kb bastardkb/charybdis/3x5/v2/splinky -km alex-miryoku

@0xcharly
Copy link
Collaborator Author

Hi,

You can see the order in which config.h and rules.mk files are evaluated here: https://docs.qmk.fm/#/hardware_keyboard_guidelines?id=configh.

To fix your specific issue, can you try adding this to your keymap's rules.mk:

OPT_DEFS += -DSPLINKY_BETA_PINOUT

?

Thanks!

0xcharly pushed a commit that referenced this issue Sep 11, 2022
The pinout of the splinky changed between the last beta batch, and the
production one. This commit updates the keyboard definition to support
the new pinout by default, while offering backward compatibility.

Define `SPLINKY_BETA_PINOUT` to build the firmware with pre-production
pinout.

Fixes #15
0xcharly pushed a commit that referenced this issue Sep 11, 2022
The pinout of the splinky changed between the last beta batch, and the
production one. This commit updates the keyboard definition to support
the new pinout by default, while offering backward compatibility.

Define `SPLINKY_BETA_PINOUT` to build the firmware with pre-production
pinout.

Fixes #15
0xcharly pushed a commit that referenced this issue Sep 11, 2022
The pinout of the splinky changed between the last beta batch, and the
production one. This commit updates the keyboard definition to support
the new pinout by default, while offering backward compatibility.

Define `SPLINKY_BETA_PINOUT` to build the firmware with pre-production
pinout.

Fixes #15
0xcharly pushed a commit that referenced this issue Sep 17, 2022
The pinout of the splinky changed between the last beta batch, and the
production one. This commit updates the keyboard definition to support
the new pinout by default, while offering backward compatibility.

Define `SPLINKY_BETA_PINOUT` to build the firmware with pre-production
pinout.

Fixes #15
0xcharly pushed a commit that referenced this issue Oct 7, 2022
The pinout of the splinky changed between the last beta batch, and the
production one. This commit updates the keyboard definition to support
the new pinout by default, while offering backward compatibility.

Define `SPLINKY_BETA_PINOUT` to build the firmware with pre-production
pinout.

Fixes #15
0xcharly added a commit that referenced this issue Oct 29, 2022
The pinout of the splinky changed between the last beta batch, and the
production one. This commit updates the keyboard definition to support
the new pinout by default, while offering backward compatibility.

Define `SPLINKY_BETA_PINOUT` to build the firmware with pre-production
pinout.

Fixes #15
0xcharly added a commit that referenced this issue Oct 29, 2022
The pinout of the splinky changed between the last beta batch, and the
production one. This commit updates the keyboard definition to support
the new pinout by default, while offering backward compatibility.

Define `SPLINKY_BETA_PINOUT` to build the firmware with pre-production
pinout.

Fixes #15
0xcharly added a commit that referenced this issue Nov 9, 2022
The pinout of the splinky changed between the last beta batch, and the
production one. This commit updates the keyboard definition to support
the new pinout by default, while offering backward compatibility.

Define `SPLINKY_BETA_PINOUT` to build the firmware with pre-production
pinout.

Fixes #15
0xcharly added a commit that referenced this issue Nov 14, 2022
The pinout of the splinky changed between the last beta batch, and the
production one. This commit updates the keyboard definition to support
the new pinout by default, while offering backward compatibility.

Define `SPLINKY_BETA_PINOUT` to build the firmware with pre-production
pinout.

Fixes #15
0xcharly added a commit that referenced this issue Nov 15, 2022
* bastardkb: cleanup blackpill configuration

Fixes #17

* bastardkb: fix splinky configuration

The pinout of the splinky changed between the last beta batch, and the
production one. This commit updates the keyboard definition to support
the new pinout by default, while offering backward compatibility.

Define `SPLINKY_BETA_PINOUT` to build the firmware with pre-production
pinout.

Fixes #15

* bastardkb: add support for STeMCell

* Update scylla/tbkmini/skeletyl outdated readmes

* bastardkb/dilemma: enable circular scroll

* bastardkb/dilemma: add initial version of the `via` keymap

* bastardkb/dilemma/assembled: add new keyboard

Fixes #20

* bastardkb/dilemma: remove elite-c

* Initial support for the Dilemma 3x5+3 Assembled RGB

* Address code review comments

* Address more comments

* Address review comments

* Address more nits

* bastardkb: split splinky-based keyboards to distinguish between Splinky v2 and v3 pinout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants