Clarify hotswap and switches for the Dilemma. #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I started my first Dilemma build, and was a bit confused by some things in the docs. First, the docs specifically call out 3D keyboards not being compatible with hotswap, but say nothing about the Dilemma. After asking on the Discord, I found out that the Dilemma also does not support hotswap, which I think covers all keyboards from BastardKB, so I don't think the "3d keyboards" qualification is necessary. Second, I couldn't find any information about what kind of switches are supported on either the docs or the product page. It would be great to add this to the product page as well, where it says "Keycaps, switches and cables not included.". I got the information on compatibility from `burkfers` on Discord.
burkfers
reviewed
Jan 5, 2025
|
Thank you for taking the time to prepare a PR. I like these changes! |
Co-authored-by: burkfers <6268175+burkfers@users.noreply.github.com>
|
Thanks for reviewing! Do you want me to squash the subsequent changes? |
burkfers
approved these changes
Jan 5, 2025
|
Squashing is one click from the PR merge screen, so no need to do it on your end (but you can if you want to). Let's get final approval from Quentin and then we're good to go. |
|
Excellent work @rcorre , thanks for your contribution! 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started my first Dilemma build, and was a bit confused by some things in the docs.
First, the docs specifically call out 3D keyboards not being compatible with hotswap,
but say nothing about the Dilemma. After asking on the Discord, I found out that the
Dilemma also does not support hotswap, which I think covers all keyboards from BastardKB,
so I don't think the "3d keyboards" qualification is necessary.
Second, I couldn't find any information about what kind of switches are supported on either
the docs or the product page. It would be great to add this to the product page as well,
where it says "Keycaps, switches and cables not included.".
I got the information on compatibility from @burkfers on Discord.