Addresses vehicle vibration issue #1 #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mitigated abnormal vehicle vibration of issue BastiaanOlij#1 by adjusting CollisionShape dimensions. The shape seems to significantly impact the strength of vehicle vibrations in Godot. This depends primarily on whether the CollisionShape length extends beyond the wheel placement, followed by a marginal significance of ColllisionShape width, regardless of wheel placement. CollisionShape depth is seemingly unimportant. The shape also seems to affect whether the vibration is introduced to situations of braking to a stop, and continuing to apply the brake when stopped. Changing wheel_friction_slip could reduce vibrations, but doing so directly impairs handling.
|
Hmm, I hadn't thought to check whether the size of the bodies collision shape would make a difference. I guess it makes sense as the forces are inacted on that body.. I have to find some time to test this some more :) Btw, note that this PR that hopefully will be in 3.0.3 or else in 3.1 makes a difference too: |
|
Excellent, I am glad you were able to determine a fundamental fix in the engine. In light of this I will close this request, as the issue will be resolved in Godot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mitigated abnormal vehicle vibration of issue #1 by adjusting CollisionShape dimensions. The shape seems to significantly impact the strength of vehicle vibrations in Godot. This depends primarily on whether the CollisionShape length extends beyond the wheel placement, followed by a marginal significance of ColllisionShape width, regardless of wheel placement. CollisionShape depth is seemingly unimportant.
The shape also seems to affect whether the vibration is introduced to situations of braking to a stop, and continuing to apply the brake when stopped.
Changing wheel_friction_slip could reduce vibrations, but doing so directly impairs handling.