allow initial food placement for 8 snakes on 7x7 board #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torbensky
requested review from
robbles,
bvanvugt and
chris-bsnake
as code owners
|
My bad, I see there are some failing tests. I'll fix those |
|
Also realized I had misunderstood the ticket. |
torbensky
commented
Jun 22, 2022
| {snakeHead.X + 1, snakeHead.Y - 1}, | ||
| {snakeHead.X + 1, snakeHead.Y + 1}, | ||
| } | ||
| isSmallBoard := b.Width*b.Height <= BoardSizeSmall*BoardSizeSmall |
There was a problem hiding this comment.
Wasn't totally sure about this. I felt like boards smaller than 7x7 shouldn't be included either though.
robbles
approved these changes
Jun 22, 2022
coreyja
added a commit
to coreyja/rules
that referenced
this pull request
Jun 26, 2022
* main: allow initial food placement for 8 snakes on 7x7 board (BattlesnakeOfficial#87) fix for readme, install as go package. go get is no longer supported (BattlesnakeOfficial#86) Add player and board size meta data to all game maps (BattlesnakeOfficial#84)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Food placement logic is altered such that small boards (7x7 or smaller) that have > 4 snakes will only spawn food in the center. This avoids a possible edge case in the original logic where the food placement for nearby snakes can overlap and throw an error.