Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Noise effect #42

Open
wants to merge 1 commit into
base: effects_refactoring
Choose a base branch
from
Open

Noise effect #42

wants to merge 1 commit into from

Conversation

Be-ing
Copy link
Owner

@Be-ing Be-ing commented Apr 30, 2020 •
edited
Loading

I came up with an interesting formula having no idea what it would
sound like. It turned out to make some gnarly noise. :)

Be careful turning this up. It gets loud.

@Be-ing Be-ing changed the base branch from effects_refactoring to effectunit_routing_not_persistent April 30, 2020 05:28
@Be-ing Be-ing changed the base branch from effectunit_routing_not_persistent to effects_refactoring April 30, 2020 05:29
@Be-ing Be-ing mentioned this pull request May 7, 2020
Closed
15 tasks
@Holzhaus
Copy link

I wanted to try this, but it doesn't build:

In file included from /home/jan/Projects/mixxx/src/effects/specialeffectchainslots.h:5,
                 from /home/jan/Projects/mixxx/src/effects/specialeffectchainslots.cpp:1:
/home/jan/Projects/mixxx/src/effects/effectsmanager.h: In member function 'EffectChainSlotPointer EffectsManager::getEqualizerEffectChainSlot(const QString&)':
/home/jan/Projects/mixxx/src/effects/effectsmanager.h:75:49: error: could not convert 'QHash<K, V>::value(const Key&) const [with Key = QString; T = QSharedPointer<EqualizerEffectChainSlot>]((* & deckGroupName))' from 'QSharedPointer<EqualizerEffectChainSlot>' to 'QSharedPointer<EffectChainSlot>'
   75 |         return m_equalizerEffectChainSlots.value(deckGroupName);
      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~
      |                                                 |
      |                                                 QSharedPointer<EqualizerEffectChainSlot>
make[2]: *** [CMakeFiles/mixxx-lib.dir/build.make:1110: CMakeFiles/mixxx-lib.dir/src/effects/specialeffectchainslots.cpp.o] Error 1

@Be-ing
add Noise effect
dfc3922 
I came up with an interesting formula having no idea what it would
sound like. It turned out to make some gnarly noise. :)
@Be-ing
Copy link
Owner Author

Be-ing commented Jul 4, 2020

@Holzhaus I cannot reproduce that build failure. I rebased this on my effects_refactoring branch.

@Be-ing Be-ing force-pushed the effects_refactoring branch 7 times, most recently from 3a519c2 to 118ec6c Compare December 1, 2020 04:03
@Be-ing Be-ing force-pushed the effects_refactoring branch 2 times, most recently from 432a89c to da2e71b Compare March 12, 2021 04:24
@github-actions
Copy link

github-actions bot commented Oct 2, 2021

This PR is marked as stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the stale label Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Be-ing @Holzhaus