Skip to content

Enforces tab indentation in codebase #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 5, 2025
Merged

Conversation

firestar300
Copy link
Contributor

@firestar300 firestar300 commented Jun 3, 2025

Issue

Cette PR répond à l'issue #431.

Description

Updates ESLint and Stylelint configuration to enforce tab indentation for improved code readability and consistency.
Also, applies tab indentation to existing JavaScript et SCSS files.

Summary by Sourcery

Enforce tab-based indentation throughout the codebase by updating linting configurations and reformatting all existing JavaScript and SCSS files to use tabs for consistency.

Enhancements:

  • Add ESLint and Stylelint rules to enforce tab indentation.
  • Reformat all existing JS and SCSS files to use tabs instead of spaces for consistent indentation.

Updates ESLint configuration to enforce tab indentation for improved code readability and consistency.
Also, applies tab indentation to existing JavaScript files.
Copy link

sourcery-ai bot commented Jun 3, 2025

Reviewer's Guide

This PR enforces tab‐based indentation for consistency by updating lint configurations and reformatting the entire codebase accordingly.

File-Level Changes

Change Details Files
Updated linting rules to enforce tabs
  • ESLint indent rule set to tabs
  • Stylelint indentation rule set to tabs
.eslintrc
.stylelintrc
Reformatted code indentation across JS and SCSS files
  • Replaced space indents with tabs throughout existing files
  • Preserved original code structure while normalizing indent style
src/js/**/*.js
src/scss/**/*.scss
Corrected import path for Poppins font mixins
  • Adjusted Poppins mixin import to use relative node_modules path
src/scss/03-base/_fonts.scss

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @firestar300 - I've reviewed your changes - here's some feedback:

  • Consider isolating all whitespace-only tabbing changes into a dedicated commit to reduce noise and make reviewing the actual functional updates easier.
  • Double-check the updated relative import path to @fontsource/poppins in _fonts.scss after the indentation changes to ensure it still resolves correctly.
Here's what I looked at during the review
  • 🟡 General issues: 4 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

ptesei
ptesei previously approved these changes Jun 3, 2025
Addresses minor code style issues identified by Sourcery.
This commit focuses on improving code readability and consistency
by destructuring objects and correcting a typo, without
altering the core functionality. Also, clears a timeout in destroy function.
@firestar300 firestar300 merged commit e47a307 into master Jun 5, 2025
1 of 3 checks passed
@firestar300 firestar300 deleted the fearture/tab-indent branch June 5, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants