-
Notifications
You must be signed in to change notification settings - Fork 18
Enforces tab indentation in codebase #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates ESLint configuration to enforce tab indentation for improved code readability and consistency. Also, applies tab indentation to existing JavaScript files.
Reviewer's GuideThis PR enforces tab‐based indentation for consistency by updating lint configurations and reformatting the entire codebase accordingly. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @firestar300 - I've reviewed your changes - here's some feedback:
- Consider isolating all whitespace-only tabbing changes into a dedicated commit to reduce noise and make reviewing the actual functional updates easier.
- Double-check the updated relative import path to @fontsource/poppins in _fonts.scss after the indentation changes to ensure it still resolves correctly.
Here's what I looked at during the review
- 🟡 General issues: 4 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
ptesei
previously approved these changes
Jun 3, 2025
Addresses minor code style issues identified by Sourcery. This commit focuses on improving code readability and consistency by destructuring objects and correcting a typo, without altering the core functionality. Also, clears a timeout in destroy function.
francoistibo
approved these changes
Jun 3, 2025
ptesei
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Cette PR répond à l'issue #431.
Description
Updates ESLint and Stylelint configuration to enforce tab indentation for improved code readability and consistency.
Also, applies tab indentation to existing JavaScript et SCSS files.
Summary by Sourcery
Enforce tab-based indentation throughout the codebase by updating linting configurations and reformatting all existing JavaScript and SCSS files to use tabs for consistency.
Enhancements: