Validate layout/page templates on context actions

Instead of validating it on every form change
BeaconCMS · Sep 15, 2023 · 86c0fb1 · 86c0fb1
1 parent 4cdb3b9
commit 86c0fb1
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/lib/beacon/content.ex b/lib/beacon/content.ex
@@ -1872,6 +1872,10 @@ defmodule Beacon.Content do
 
   ## Utils
 
+  defp do_validate_template(changeset, field, _format, nil = _template, _metadata) do
+    Changeset.add_error(changeset, field, "can't be blank", compilation_error: nil)
+  end
+
   defp do_validate_template(changeset, field, :heex = _format, template, metadata) when is_binary(template) do
     Changeset.validate_change(changeset, field, fn ^field, template ->
       case Beacon.Template.HEEx.compile(template, metadata) do

diff --git a/lib/beacon/content/layout.ex b/lib/beacon/content/layout.ex
@@ -47,6 +47,6 @@ defmodule Beacon.Content.Layout do
   def changeset(%__MODULE__{} = layout, attrs) do
     layout
     |> cast(attrs, [:site, :title, :template, :meta_tags, :resource_links])
-    |> validate_required([:site, :title, :template])
+    |> validate_required([:site, :title])
   end
 end
diff --git a/lib/beacon/content/page.ex b/lib/beacon/content/page.ex
@@ -82,7 +82,6 @@ defmodule Beacon.Content.Page do
     |> unique_constraint([:path, :site])
     |> validate_required([
       :site,
-      :template,
       :layout_id,
       :format
     ])
@@ -119,7 +118,6 @@ defmodule Beacon.Content.Page do
     |> unique_constraint([:path, :site])
     |> validate_required([
       :site,
-      :template,
       :layout_id,
       :format
     ])