Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core -> Components and Pages: Make stylesheets optional #150

Closed
leandrocp opened this issue Mar 2, 2023 · 1 comment · Fixed by #271
Closed

Core -> Components and Pages: Make stylesheets optional #150

leandrocp opened this issue Mar 2, 2023 · 1 comment · Fixed by #271
Assignees
@leandrocp
Labels
enhancement New feature or improvement good first issue Good for newcomers help wanted Looking for contributors
Milestone
v0.1.0

Comments

@leandrocp
Copy link
Contributor

leandrocp commented Mar 2, 2023 •
edited
Loading

The minimum required to create a page should be a layout. But currently a stylesheet is also required, which shouldn't be.

We want to remove this requirement in fixtures

beacon/test/beacon_web/live/page_live_test.exs

Lines 154 to 155 in bb2627e

# TODO: make stylesheet optional
stylesheet_fixture()
and remove :stylesheet_urls from the required list

beacon/lib/beacon/layouts/layout.ex

Lines 32 to 33 in bb2627e

# TODO: make stylesheet optional
|> validate_required([:site, :title, :body, :stylesheet_urls])

@leandrocp leandrocp added the enhancement New feature or improvement label Mar 2, 2023
@AZholtkevych AZholtkevych moved this to Todo in Beacon Mar 2, 2023
@AZholtkevych AZholtkevych changed the title Make stylesheets optional Core -> Components and Pages: Make stylesheets optional Apr 27, 2023
@AZholtkevych AZholtkevych added good first issue Good for newcomers help wanted Looking for contributors app:core labels Apr 27, 2023
@AZholtkevych AZholtkevych mentioned this issue May 1, 2023
Closed
29 tasks
@AZholtkevych AZholtkevych mentioned this issue Jun 9, 2023
Closed
18 tasks
@polvalente
Copy link
Contributor

Taking a look into this issue

@polvalente polvalente mentioned this issue Jun 28, 2023
Merged
@AZholtkevych AZholtkevych moved this from Todo to Done in Beacon Jun 30, 2023
@AZholtkevych AZholtkevych added this to the Version 0.1.0 milestone Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leandrocp leandrocp

Labels
enhancement New feature or improvement good first issue Good for newcomers help wanted Looking for contributors
Projects
Beacon
Status: Done
Milestone
v0.1.0
Development

Successfully merging a pull request may close this issue.

fix: remove requirement on :stylesheet_urls from Layout schema polvalente/beacon
3 participants
@leandrocp @polvalente @AZholtkevych