fix: remove requirement on :stylesheet_urls from Layout schema #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polvalente
commented
Jun 28, 2023
| @@ -35,6 +35,7 @@ beacon-*.tar | |||
| /assets/node_modules | |||
| # tailwind.install | |||
| /assets/css/app.css | |||
| /assets/tailwind.config.js | |||
There was a problem hiding this comment.
This file was added during the setup it seems, and I'd accidentally commited it
polvalente
commented
Jun 28, 2023
polvalente
commented
Jun 28, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #150
It turns out that the stylesheets were already optional as the changeset was configured.
An additional validation through either
validate_changeor a combination ofget_field/get_changeandadd_errormust be done if an array field is to be considered invalid on an empty list, but this is not a concern in any of the other schemas which I found in the code.