Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route and Resource Loading: Add --path to beacon.install generator #306

Closed
leandrocp opened this issue Aug 3, 2023 · 4 comments · Fixed by #387
Closed

Route and Resource Loading: Add --path to beacon.install generator #306

leandrocp opened this issue Aug 3, 2023 · 4 comments · Fixed by #387
Assignees
Labels
enhancement New feature or improvement good first issue Good for newcomers help wanted Looking for contributors
Milestone

Comments

@leandrocp
Copy link
Contributor

The beacon.install mix task accepts a --site option which generates the following scope in the router:

  scope "/" do
    pipe_through :browser
    beacon_site "/my_site", site: :my_site
  end

We need to add a new optional --path option that allows changing the first argument of beacon_site, example:

mix beacon.install --site my_site --path /

Would generate:

  scope "/" do
    pipe_through :browser
    beacon_site "/", site: :my_site
  end

If not specified it takes the value from --site.

@leandrocp leandrocp added enhancement New feature or improvement good first issue Good for newcomers help wanted Looking for contributors labels Aug 3, 2023
@AZholtkevych AZholtkevych moved this to Todo in Beacon Aug 3, 2023
@AZholtkevych AZholtkevych changed the title Mix Task -> add --path to beacon.install generator Admin -> Route and Resource Loading: add --path to beacon.install generator Aug 8, 2023
@AZholtkevych AZholtkevych changed the title Admin -> Route and Resource Loading: add --path to beacon.install generator Core -> Route and Resource Loading: add --path to beacon.install generator Aug 8, 2023
@AZholtkevych AZholtkevych added this to the Version 0.1.0 milestone Sep 15, 2023
@AZholtkevych AZholtkevych mentioned this issue Sep 25, 2023
29 tasks
@AZholtkevych AZholtkevych changed the title Core -> Route and Resource Loading: add --path to beacon.install generator Core -> Route and Resource Loading: add --path to beacon.install generator Sep 25, 2023
@AZholtkevych AZholtkevych changed the title Core -> Route and Resource Loading: add --path to beacon.install generator Core -> Route and Resource Loading: Add --path to beacon.install generator Sep 25, 2023
@leandrocp leandrocp removed the status in Beacon Oct 20, 2023
@leandrocp leandrocp moved this to Todo in Beacon Oct 20, 2023
@AZholtkevych AZholtkevych changed the title Core -> Route and Resource Loading: Add --path to beacon.install generator Route and Resource Loading: Add --path to beacon.install generator Oct 23, 2023
@a8t
Copy link

a8t commented Oct 25, 2023

Still looking for help on this?

@leandrocp
Copy link
Contributor Author

Still looking for help on this?

Yep. A PR is welcome!

@edborsa
Copy link
Contributor

edborsa commented Dec 15, 2023

#387

@leandrocp
Copy link
Contributor Author

Closed by #387

/cc @AZholtkevych

@AZholtkevych AZholtkevych moved this from Todo to Done in Beacon Jan 9, 2024
@AZholtkevych AZholtkevych added this to the v0.1.0 milestone Jan 9, 2024
@AZholtkevych AZholtkevych mentioned this issue Apr 21, 2024
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement good first issue Good for newcomers help wanted Looking for contributors
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants