Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Route and Resource Loading Add --path to beacon.install generator #387

Merged
merged 6 commits into from
Jan 9, 2024
Merged

Feat: Route and Resource Loading Add --path to beacon.install generator #387

merged 6 commits into from
Jan 9, 2024

Conversation

edborsa
Copy link
Contributor

@edborsa edborsa commented Dec 15, 2023

@edborsa
helper valid_path?
6c693ac 
Signed-off-by: Eduardo Borsa <borsa.dado@gmail.com>
@edborsa
update template
22c52ec 
Signed-off-by: Eduardo Borsa <borsa.dado@gmail.com>
@edborsa
added and validated the --path opt
c02aa1f 
Signed-off-by: Eduardo Borsa <borsa.dado@gmail.com>
@edborsa edborsa mentioned this pull request Dec 15, 2023
Closed
leandrocp
leandrocp requested changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@leandrocp leandrocp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments. Thanks

lib/beacon/types/site.ex Outdated Show resolved Hide resolved
lib/beacon/types/site.ex Outdated Show resolved Hide resolved
lib/beacon/types/site.ex Show resolved Hide resolved
lib/mix/tasks/install.ex Outdated Show resolved Hide resolved
edborsa added 3 commits January 4, 2024 06:27
@edborsa
Add regex
3273712 
Signed-off-by: Eduardo Borsa <borsa.dado@gmail.com>
@edborsa
fix style
d7eeb81 
Signed-off-by: Eduardo Borsa <borsa.dado@gmail.com>
@edborsa
let beacon types site handle validation
162a51a 
Signed-off-by: Eduardo Borsa <borsa.dado@gmail.com>
@leandrocp
Copy link
Contributor

❤️

@leandrocp leandrocp merged commit bbed1a5 into BeaconCMS:main Jan 9, 2024
3 checks passed
@AZholtkevych AZholtkevych linked an issue Jan 9, 2024 that may be closed by this pull request
Route and Resource Loading: Add --path to beacon.install generator #306
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrocp leandrocp leandrocp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Route and Resource Loading: Add --path to beacon.install generator
2 participants
@edborsa @leandrocp