Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page Builder: Component to load embedded resources (oEmbed) #349

Closed
leandrocp opened this issue Sep 13, 2023 · 5 comments · Fixed by #507
Closed

Page Builder: Component to load embedded resources (oEmbed) #349

leandrocp opened this issue Sep 13, 2023 · 5 comments · Fixed by #507
Assignees
@APB9785
Labels
area:component Phoenix components and Page Builder components enhancement New feature or improvement good first issue Good for newcomers help wanted Looking for contributors roadmap Priority issues that will be released in the short term
Milestone
v0.1.0

Comments

@leandrocp
Copy link
Contributor

leandrocp commented Sep 13, 2023 •
edited
Loading

Add a new component embed/1 into https://github.com/BeaconCMS/beacon/blob/main/lib/beacon_web/components/components.ex that takes an URL, unfurl such resource, and render the html property.

For example, given that someone adds the following snippet into a page template:

<BeaconWeb.Components.embed url="https://www.youtube.com/watch?v=giYbq4HmfGA">

The resulting markup should look like:

<iframe width=\"200\" height=\"113\" src=\"https://www.youtube.com/embed/giYbq4HmfGA?feature=oembed\" frameborder=\"0\" allow=\"accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share\" allowfullscreen title=\"ElixirConf 2023 - José Valim - The foundations of the Elixir type system\"></iframe>

See https://oembed.com/

Using a library like https://hex.pm/packages/oembed helps to parse the many available providers.
@AZholtkevych AZholtkevych changed the title Add support for embedded resources Core -> Route and Resource Loading: Add support for embedded resources Sep 13, 2023
@AZholtkevych AZholtkevych added this to the Version 0.1.0 milestone Sep 15, 2023
@AZholtkevych AZholtkevych moved this to Todo in Beacon Sep 20, 2023
@AZholtkevych AZholtkevych mentioned this issue Sep 25, 2023
Closed
29 tasks
@leandrocp leandrocp removed the status in Beacon Oct 20, 2023
@leandrocp leandrocp moved this to Todo in Beacon Oct 20, 2023
@leandrocp leandrocp added the proposal Idea in research phase label Oct 20, 2023
@AZholtkevych AZholtkevych changed the title Core -> Route and Resource Loading: Add support for embedded resources Route and Resource Loading: Add support for embedded resources Oct 23, 2023
@AZholtkevych AZholtkevych moved this from Todo to Backlog in Beacon Oct 23, 2023
@leandrocp leandrocp changed the title Route and Resource Loading: Add support for embedded resources Route and Resource Loading: Add a component to load embedded resources (oEmbed) Oct 30, 2023
@leandrocp leandrocp added enhancement New feature or improvement help wanted Looking for contributors and removed proposal Idea in research phase labels Oct 30, 2023
@leandrocp leandrocp moved this from Backlog to Todo in Beacon Oct 30, 2023
@leandrocp leandrocp added the good first issue Good for newcomers label Oct 31, 2023
@leandrocp leandrocp changed the title Route and Resource Loading: Add a component to load embedded resources (oEmbed) Page Builder: Component to load embedded resources (oEmbed) Nov 1, 2023
@leandrocp leandrocp removed this from the v0.1.0 milestone Nov 1, 2023
@AZholtkevych AZholtkevych added this to the v0.1.0 milestone Nov 16, 2023
@leandrocp leandrocp mentioned this issue Dec 4, 2023
Open
@edborsa
Copy link
Contributor

edborsa commented Dec 30, 2023

Hey! I created a PR for this issue:
#389

@leandrocp
Copy link
Contributor Author

Hi @edborsa I guess you meant that PR #389 is to solve the issue #357? :)

A PR for this issue is also very welcome. AFAIK @APB9785 haven't started working on this one yet.

@APB9785
Copy link
Contributor

APB9785 commented Jan 9, 2024

That's right, I have not yet started on this.

@edborsa
Copy link
Contributor

edborsa commented Jan 10, 2024

Oh, cool!
I'll tackle this next then ;)

@edborsa edborsa mentioned this issue Jan 11, 2024
Closed
@AZholtkevych AZholtkevych linked a pull request Jan 12, 2024 that will close this issue
Feat: Embedded Resource Component #391
Closed
@AZholtkevych AZholtkevych moved this from Todo to In Progress in Beacon Jan 12, 2024
@AZholtkevych AZholtkevych assigned leandrocp and unassigned APB9785 Jan 26, 2024
@AZholtkevych AZholtkevych moved this from In Progress to Blocked in Beacon Apr 1, 2024
@AZholtkevych AZholtkevych moved this from Blocked to On Hold in Beacon Apr 1, 2024
@AZholtkevych AZholtkevych mentioned this issue Apr 20, 2024
Closed
45 tasks
@bcardarella
Copy link
Contributor

Correct PR #391

@bcardarella bcardarella self-assigned this May 2, 2024
@leandrocp leandrocp added area:component Phoenix components and Page Builder components roadmap Priority issues that will be released in the short term labels May 17, 2024
@APB9785 APB9785 mentioned this issue May 24, 2024
Merged
@APB9785 APB9785 self-assigned this May 24, 2024
@APB9785 APB9785 moved this from On Hold to Code Review in Beacon May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@APB9785 APB9785

Labels
area:component Phoenix components and Page Builder components enhancement New feature or improvement good first issue Good for newcomers help wanted Looking for contributors roadmap Priority issues that will be released in the short term
Projects
Beacon
Status: Code Review
Milestone
v0.1.0
Development

Successfully merging a pull request may close this issue.

Embedded resource component BeaconCMS/beacon
Feat: Embedded Resource Component edborsa/beacon
5 participants
@bcardarella @leandrocp @edborsa @APB9785 @AZholtkevych